[PR #13035] [MERGED] WIP for adding BellSound to schema #29348

Open
opened 2026-01-31 09:34:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13035
Author: @pizzaz93
Created: 5/4/2022
Status: ✅ Merged
Merged: 5/10/2022
Merged by: @DHowett

Base: main ← Head: patch-1


📝 Commits (7)

  • 1aa478c Update profiles.schema.json
  • 1aa717a Update profiles.schema.json
  • 6dde003 Apply suggestions from code review
  • d5ced6f Update profiles.schema.json
  • ef7e39d Apply suggestions from code review
  • ed2c067 Update profiles.schema.json
  • c151289 Update doc/cascadia/profiles.schema.json

📊 Changes

1 file changed (+19 additions, -1 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+19 -1)

📄 Description

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13035 **Author:** [@pizzaz93](https://github.com/pizzaz93) **Created:** 5/4/2022 **Status:** ✅ Merged **Merged:** 5/10/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (7) - [`1aa478c`](https://github.com/microsoft/terminal/commit/1aa478c15dbee092016a64b655be7c445ba586cd) Update profiles.schema.json - [`1aa717a`](https://github.com/microsoft/terminal/commit/1aa717a60d9e7cded96b83fda98c88be24adbb94) Update profiles.schema.json - [`6dde003`](https://github.com/microsoft/terminal/commit/6dde0034cd4ef40eeff9a68952f116f3d7a5c5d0) Apply suggestions from code review - [`d5ced6f`](https://github.com/microsoft/terminal/commit/d5ced6fd351b6f4217a681035754056c9fd86ba1) Update profiles.schema.json - [`ef7e39d`](https://github.com/microsoft/terminal/commit/ef7e39ddaf461a5380a8d6cbe81f35ef0d77408c) Apply suggestions from code review - [`ed2c067`](https://github.com/microsoft/terminal/commit/ed2c067c3763af894c478a4de6b381d21c447c34) Update profiles.schema.json - [`c151289`](https://github.com/microsoft/terminal/commit/c151289d26ae4936c76ad90ddf7758ac909c1a85) Update doc/cascadia/profiles.schema.json ### 📊 Changes **1 file changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+19 -1) </details> ### 📄 Description <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #12504 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Documentation previously added by another contributor https://docs.microsoft.com/en-us/windows/terminal/customize-settings/profile-advanced#bell-sound-preview * [X] Schema updated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29348