starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13052] [MERGED] Make sure the virtual viewport doesn't go negative #29357

New Issue
Open
opened 2026-01-31 09:34:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:34:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13052
Author: @j4james
Created: 5/7/2022
Status: ✅ Merged
Merged: 5/9/2022
Merged by: @undefined

Base: main ← Head: fix-virtual-viewport

📝 Commits (2)

  • bf710e2 Make sure virtual viewport doesn't go negative.
  • 2cc3add Add another virtual bottom unit test.

📊 Changes

2 files changed (+35 additions, -2 deletions)

View changed files

📝 src/host/screenInfo.cpp (+5 -2)
📝 src/host/ut_host/ScreenBufferTests.cpp (+30 -0)

📄 Description

Summary of the Pull Request

When calculating the position of the virtual bottom after a resize with
reflow, it was possible for it to end up less than the height of the
viewport. This meant that the top of the virtual viewport would be
negative, which resulted in other operations failing further down the
line. This PR updates the virtual bottom calculation to fix that
scenario.

References

This was probably a regression introduced in PR #12972.

PR Checklist

Validation Steps Performed

I wasn't able to replicate the exact case described in issue #13034,
because I don't have Windows 11, so can't configure the default
terminal. However, I was able to reproduce a similar failure using a
SetConsoleScreenBufferInfoEx call, and I've confirmed that this PR
has fixed that.

I've also added another screen buffer test to make sure the
ResizeWithReflow method doesn't shrink the virtual bottom when
resizing at the top of the buffer.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13052 **Author:** [@j4james](https://github.com/j4james) **Created:** 5/7/2022 **Status:** ✅ Merged **Merged:** 5/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `fix-virtual-viewport` --- ### 📝 Commits (2) - [`bf710e2`](https://github.com/microsoft/terminal/commit/bf710e2bd928469713ccf4bf46bb3c8f91a113c7) Make sure virtual viewport doesn't go negative. - [`2cc3add`](https://github.com/microsoft/terminal/commit/2cc3add925fe5cdce123ce5cb5320715612132c6) Add another virtual bottom unit test. ### 📊 Changes **2 files changed** (+35 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/host/screenInfo.cpp` (+5 -2) 📝 `src/host/ut_host/ScreenBufferTests.cpp` (+30 -0) </details> ### 📄 Description ## Summary of the Pull Request When calculating the position of the virtual bottom after a resize with reflow, it was possible for it to end up less than the height of the viewport. This meant that the top of the virtual viewport would be negative, which resulted in other operations failing further down the line. This PR updates the virtual bottom calculation to fix that scenario. ## References This was probably a regression introduced in PR #12972. ## PR Checklist * [x] Closes #13034 * [x] CLA signed. * [x] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [x] I've discussed this with core contributors already. Issue number where discussion took place: #13034 ## Validation Steps Performed I wasn't able to replicate the exact case described in issue #13034, because I don't have Windows 11, so can't configure the default terminal. However, I was able to reproduce a similar failure using a `SetConsoleScreenBufferInfoEx` call, and I've confirmed that this PR has fixed that. I've also added another screen buffer test to make sure the `ResizeWithReflow` method doesn't shrink the virtual bottom when resizing at the top of the buffer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?