starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13092] [MERGED] Fix various unit/feature test bugs #29378

New Issue
Open
opened 2026-01-31 09:34:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:34:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13092
Author: @lhecker
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/13/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/4015-split1

📝 Commits (1)

  • 68fb6c2 Fix various unit/feature test bugs

📊 Changes

5 files changed (+25 additions, -18 deletions)

View changed files

📝 src/host/ft_host/API_DimensionsTests.cpp (+8 -2)
📝 src/host/ft_host/API_FontTests.cpp (+2 -2)
📝 src/host/ft_host/InitTests.cpp (+2 -0)
📝 src/terminal/adapter/ut_adapter/inputTest.cpp (+1 -1)
📝 src/terminal/parser/ut_parser/InputEngineTest.cpp (+12 -13)

📄 Description

This commit fixes various bugs in our unit/feature test suite:

  • 2 tests failed at 150% scale.
  • The "null key" (@ on a US keyboard) isn't necessarily Shift+2.
    The proper way to get it is with LOBYTE(VkKeyScanW(0))
  • InputEngineTest::C0Test never worked as it overwrote
    the loop variable, exiting the loop early

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13092 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/13/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/4015-split1` --- ### 📝 Commits (1) - [`68fb6c2`](https://github.com/microsoft/terminal/commit/68fb6c21c62f8889e33e75f8c131ed24db5905ea) Fix various unit/feature test bugs ### 📊 Changes **5 files changed** (+25 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ft_host/API_DimensionsTests.cpp` (+8 -2) 📝 `src/host/ft_host/API_FontTests.cpp` (+2 -2) 📝 `src/host/ft_host/InitTests.cpp` (+2 -0) 📝 `src/terminal/adapter/ut_adapter/inputTest.cpp` (+1 -1) 📝 `src/terminal/parser/ut_parser/InputEngineTest.cpp` (+12 -13) </details> ### 📄 Description This commit fixes various bugs in our unit/feature test suite: * 2 tests failed at 150% scale. * The "null key" (@ on a US keyboard) isn't necessarily Shift+2. The proper way to get it is with `LOBYTE(VkKeyScanW(0))` * `InputEngineTest::C0Test` never worked as it overwrote the loop variable, exiting the loop early --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?