starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13098] [MERGED] Revert "Hide the window from DWM until we're finished... (#12979)" #29385

New Issue
Open
opened 2026-01-31 09:34:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:34:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13098
Author: @carlos-zamora
Created: 5/13/2022
Status: ✅ Merged
Merged: 5/13/2022
Merged by: @DHowett

Base: main ← Head: dev/cazamor/revert-dwm

📝 Commits (1)

  • 11bdf29 Revert "Hide the window from DWM until we're finished with initialization (#12979)"

📊 Changes

10 files changed (+25 additions, -114 deletions)

View changed files

📝 .github/actions/spelling/allow/apis.txt (+0 -2)
📝 src/cascadia/TerminalApp/AppLogic.h (+0 -1)
📝 src/cascadia/TerminalApp/AppLogic.idl (+0 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+2 -47)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.idl (+1 -1)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+7 -45)
📝 src/cascadia/WindowsTerminal/AppHost.h (+1 -9)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+10 -4)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+2 -2)

📄 Description

This reverts commit 14098d71f2.

Summary of the Pull Request

@zadjii-msft found that this is causing persisted windows on a secondary monitor to shrink a little each time. We're choosing to revert this commit until that gets resolved.

References

#12979

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13098 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 5/13/2022 **Status:** ✅ Merged **Merged:** 5/13/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/cazamor/revert-dwm` --- ### 📝 Commits (1) - [`11bdf29`](https://github.com/microsoft/terminal/commit/11bdf298159b1af2d04104a1ee2966bcbee214b3) Revert "Hide the window from DWM until we're finished with initialization (#12979)" ### 📊 Changes **10 files changed** (+25 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/apis.txt` (+0 -2) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+0 -1) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+0 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+2 -47) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.idl` (+1 -1) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+7 -45) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+1 -9) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+10 -4) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+2 -2) </details> ### 📄 Description This reverts commit 14098d71f22225765c5c71907893cd86cc1738a6. ## Summary of the Pull Request @zadjii-msft found that this is causing persisted windows on a secondary monitor to shrink a little each time. We're choosing to revert this commit until that gets resolved. ## References #12979 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?