[PR #13145] [MERGED] Fix the SUI being in the wrong Theme color #29406

Open
opened 2026-01-31 09:34:42 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13145
Author: @zadjii-msft
Created: 5/23/2022
Status: Merged
Merged: 5/23/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/another-sui-bg-bug


📝 Commits (3)

📊 Changes

2 files changed (+32 additions, -12 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+0 -10)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+32 -2)

📄 Description

ThemeResources are a persistent pain.

Regressed in #13083. See also #12775 et. al.

We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past.

  • Fixes something we noticed right before shipping

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13145 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/23/2022 **Status:** ✅ Merged **Merged:** 5/23/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/another-sui-bg-bug` --- ### 📝 Commits (3) - [`db7cb6d`](https://github.com/microsoft/terminal/commit/db7cb6d428b644ce5547e8234ed476cb71537aa1) Fix the SUI being in the wrong Theme color - [`26540e3`](https://github.com/microsoft/terminal/commit/26540e3b799f439321f505a6747d7d00ef9b00e4) dead space(s) - [`1c1aff4`](https://github.com/microsoft/terminal/commit/1c1aff485823f321a80ccb1ea50cca43193ccdd2) typos are hard ### 📊 Changes **2 files changed** (+32 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+0 -10) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+32 -2) </details> ### 📄 Description ThemeResources are a persistent pain. Regressed in #13083. See also #12775 et. al. We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past. * [x] Fixes something we noticed right before shipping --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:42 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29406