[PR #13178] [MERGED] Add support for tab.background to themes #29414

Closed
opened 2026-01-31 09:34:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13178
Author: @zadjii-msft
Created: 5/25/2022
Status: Merged
Merged: 7/7/2022
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/f/702-link-tab-to-terminal


📝 Commits (10+)

  • 15e4fd9 Settings project builds at least
  • 7e0ae35 this fixes the App bits as well
  • 00c135b on reload, this changes the BG of the titlebar, but not the tab view
  • b4cd7b3 this is better. Apphost is gonna need to be involved anyways so fuck it
  • 9627483 okay so i bet that resource changed. Whatever, we'll work with it.
  • 84805f5 dumbly accept alpha channel in colors
  • 9670d13 mica works, but the titlebar looks DUMB
  • c555e6e this did seem to work, but will it work for acrylic?
  • 01f07be okay so you can't change a solid brush to an acylic one at runtime
  • ee9333a A pile of dead ends.

📊 Changes

9 files changed (+86 additions, -26 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabManagement.cpp (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+18 -6)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+33 -2)
📝 src/cascadia/TerminalApp/TerminalTab.h (+2 -1)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+5 -1)
📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+6 -0)
📝 src/cascadia/TerminalSettingsModel/Theme.h (+12 -13)
📝 src/cascadia/TerminalSettingsModel/Theme.idl (+7 -0)

📄 Description

Summary of the Pull Request

Adds support for the tab.background property to themes. This is also a ThemeColor, so it accepts, colors, accent, and terminalBackground, just like everything else.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

I apparently left behing an optional color in TerminalTab for theme colors some time ago, just never used it. Crazy, huh?

Validation Steps Performed

gifs below


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13178 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/25/2022 **Status:** ✅ Merged **Merged:** 7/7/2022 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/f/702-link-tab-to-terminal` --- ### 📝 Commits (10+) - [`15e4fd9`](https://github.com/microsoft/terminal/commit/15e4fd9be96079e9ef1d5114ee3a2d441b7a4aef) Settings project builds at least - [`7e0ae35`](https://github.com/microsoft/terminal/commit/7e0ae358fba206c10663a829fcbbee97a2477732) this fixes the App bits as well - [`00c135b`](https://github.com/microsoft/terminal/commit/00c135b4d44cdf5684fa5ce895e9ecf257dc1b8d) on reload, this changes the BG of the titlebar, but not the tab view - [`b4cd7b3`](https://github.com/microsoft/terminal/commit/b4cd7b3d71adba9bfa93aa4362513b5d1eeb5a7d) this is better. Apphost is gonna need to be involved anyways so fuck it - [`9627483`](https://github.com/microsoft/terminal/commit/9627483f5668531bce053ef5eafd75f3bec3cbf4) okay so i bet that resource changed. Whatever, we'll work with it. - [`84805f5`](https://github.com/microsoft/terminal/commit/84805f59aab864cb91256d85395d32d932955d1f) dumbly accept alpha channel in colors - [`9670d13`](https://github.com/microsoft/terminal/commit/9670d139a6449ea3e0a79f1006127271d0f3c733) mica works, but the titlebar looks DUMB - [`c555e6e`](https://github.com/microsoft/terminal/commit/c555e6efca7a00743e1b2b5c540bafea901b09f8) this did seem to work, but will it work for acrylic? - [`01f07be`](https://github.com/microsoft/terminal/commit/01f07be64f957e66f2cb95c2605a95dfcd1fd5bc) okay so you can't change a solid brush to an acylic one at runtime - [`ee9333a`](https://github.com/microsoft/terminal/commit/ee9333af13d5323f257f993ab3f6847ef8dc48c9) A pile of dead ends. ### 📊 Changes **9 files changed** (+86 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+18 -6) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+33 -2) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+5 -1) 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+6 -0) 📝 `src/cascadia/TerminalSettingsModel/Theme.h` (+12 -13) 📝 `src/cascadia/TerminalSettingsModel/Theme.idl` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds support for the `tab.background` property to themes. This is also a ThemeColor, so it accepts, colors, `accent`, and `terminalBackground`, just like everything else. ## References * See #3327 ## PR Checklist * [x] Closes #702 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated - YUP ## Detailed Description of the Pull Request / Additional comments I apparently left behing an optional color in TerminalTab for theme colors some time ago, just never used it. Crazy, huh? ## Validation Steps Performed gifs below --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29414