[PR #13179] [MERGED] Implement MVVM for Color Schemes #29422

Open
opened 2026-01-31 09:34:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13179
Author: @PankajBhojwani
Created: 5/25/2022
Status: Merged
Merged: 7/29/2022
Merged by: @undefined

Base: mainHead: dev/pabhoj/sui_follow_ups


📝 Commits (10+)

📊 Changes

15 files changed (+711 additions, -438 deletions)

View changed files

src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.cpp (+138 -0)
src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.h (+67 -0)
src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.idl (+33 -0)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp (+18 -331)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.h (+3 -39)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.idl (+4 -30)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+145 -17)
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.cpp (+188 -0)
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.h (+49 -0)
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.idl (+24 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+4 -3)
📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+18 -0)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+17 -17)

📄 Description

Summary of the Pull Request

Implements the MVVM style for the Color Schemes editor

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • I work here

Detailed Description of the Pull Request / Additional comments

Introduces:

  • ColorSchemesPageViewModel: The view model responsible for the entire color schemes page. Handles what the current scheme is, adding/deleting/renaming schemes
  • ColorSchemeViewModel: A view model class for individual color schemes

Validation Steps Performed

Manually tested:

  • Edit a color scheme
  • Add new color scheme
  • Rename a color scheme
  • Delete a color scheme

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13179 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 5/25/2022 **Status:** ✅ Merged **Merged:** 7/29/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/sui_follow_ups` --- ### 📝 Commits (10+) - [`d447166`](https://github.com/microsoft/terminal/commit/d447166863504e4cff4e8fa90db960409214b299) invoking rightmost breadcrumb does nothing - [`5430de6`](https://github.com/microsoft/terminal/commit/5430de6e098d330e35538bfa0902632bccafe47e) partway through color scheme MVVM - [`447c1be`](https://github.com/microsoft/terminal/commit/447c1be9f20ba851d35999fe6c716a558fce0912) main page now holds vector of csvms - [`1342d92`](https://github.com/microsoft/terminal/commit/1342d92c124ecd7a28ec883d61ae4caa34c6bec9) conflict - [`93b8ecb`](https://github.com/microsoft/terminal/commit/93b8ecbc0ca077ae43c0476c0e8699c451077a27) need to update event handlers - [`987002e`](https://github.com/microsoft/terminal/commit/987002ee1e8ce7dcd16d2c9efffdc7db56c93c08) propagate changes to scheme - [`f5fef4e`](https://github.com/microsoft/terminal/commit/f5fef4ee84d478946e66455caf470abf65630376) color table colors ... - [`152974d`](https://github.com/microsoft/terminal/commit/152974da5ecb7ec32b4fc3254458fcb600e02812) delete works - [`65fc789`](https://github.com/microsoft/terminal/commit/65fc789a8f52aba1280dcfe8077d8869eea577f5) page view model is up - [`a51c166`](https://github.com/microsoft/terminal/commit/a51c166e55277dcbc168de70ed286b53545bfeeb) rename and delete work ### 📊 Changes **15 files changed** (+711 additions, -438 deletions) <details> <summary>View changed files</summary> ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.cpp` (+138 -0) ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.h` (+67 -0) ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemeViewModel.idl` (+33 -0) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp` (+18 -331) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.h` (+3 -39) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.idl` (+4 -30) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+145 -17) ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.cpp` (+188 -0) ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.h` (+49 -0) ➕ `src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.idl` (+24 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+4 -3) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+18 -0) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+17 -17) </details> ### 📄 Description ## Summary of the Pull Request Implements the MVVM style for the Color Schemes editor ## PR Checklist * [x] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I work here ## Detailed Description of the Pull Request / Additional comments Introduces: - `ColorSchemesPageViewModel`: The view model responsible for the entire color schemes page. Handles what the current scheme is, adding/deleting/renaming schemes - `ColorSchemeViewModel`: A view model class for individual color schemes ## Validation Steps Performed Manually tested: - Edit a color scheme - Add new color scheme - Rename a color scheme - Delete a color scheme --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29422