[PR #13219] [MERGED] Introduce toggleBlockSelection action #29431

Open
opened 2026-01-31 09:34:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13219
Author: @carlos-zamora
Created: 6/2/2022
Status: Merged
Merged: 6/7/2022
Merged by: @undefined

Base: mainHead: dev/cazamor/ks/toggleBlockSelection


📝 Commits (1)

  • e13a1aa Introduce toggleBlockSelection action

📊 Changes

12 files changed (+40 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+10 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+12 -0)
📝 src/cascadia/TerminalControl/ControlCore.h (+1 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+5 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -0)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+2 -1)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+3 -0)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+1 -0)

📄 Description

Summary of the Pull Request

This introduced the toggleBlockSelection action to allow users to create a block selection using only the keyboard. This is not bound to any keys by default, however it is added to the command palette.

References

#4993 - Epic
#5804 - Spec

Validation Steps Performed

  • Mark mode always starts in line selection mode
  • Mouse selections are always in line selection mode by default
  • Can toggle block selection for an existing selection (regardless of how it was created)
  • The selection is copied properly (aka, no rendering issues)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13219 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/2/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/ks/toggleBlockSelection` --- ### 📝 Commits (1) - [`e13a1aa`](https://github.com/microsoft/terminal/commit/e13a1aafd726039c27722dcbccfc8fc8688317f4) Introduce `toggleBlockSelection` action ### 📊 Changes **12 files changed** (+40 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+10 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+12 -0) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+1 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+5 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -0) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+3 -0) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request This introduced the `toggleBlockSelection` action to allow users to create a block selection using only the keyboard. This is not bound to any keys by default, however it is added to the command palette. ## References #4993 - Epic #5804 - Spec ## Validation Steps Performed - [X] Mark mode always starts in line selection mode - [X] Mouse selections are always in line selection mode by default - [X] Can toggle block selection for an existing selection (regardless of how it was created) - [X] The selection is copied properly (aka, no rendering issues) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:52 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29431