starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13244] [MERGED] Remove most uses of CompareInBounds #29439

New Issue
Closed
opened 2026-01-31 09:34:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:34:55 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13244
Author: @carlos-zamora
Created: 6/8/2022
Status: ✅ Merged
Merged: 7/1/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/remove-compareInBounds

📝 Commits (7)

  • 9596b06 Remove most uses of CompareInBounds
  • 4ce925e address PR comments
  • b105d68 clamp to inclusive pos & compare returns 0/1
  • e9b2ffc fix test
  • e0695ec make 'MoveToNextGlyph' prettier
  • 49c33d9 Merge branch 'main' into dev/cazamor/remove-compareInBounds
  • c98940a backwards

📊 Changes

6 files changed (+55 additions, -63 deletions)

View changed files

📝 src/buffer/out/textBuffer.cpp (+20 -10)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+3 -3)
📝 src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp (+2 -2)
📝 src/types/UiaTextRangeBase.cpp (+23 -29)
📝 src/types/inc/viewport.hpp (+2 -2)
📝 src/types/viewport.cpp (+5 -17)

📄 Description

Summary of the Pull Request

Replaces most uses of Viewport::CompareInBounds() with til::point's < and > operators. CompareInBounds has been the cause of a bunch of UIA crashes over the years. Replacing them entirely ensures that the FAILFAST_IF isn't ever touched.

Unfortunately, we still need IncrementInBounds and DecrementInBounds to have support for that exclusive end.

References

#13183

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13244 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/8/2022 **Status:** ✅ Merged **Merged:** 7/1/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/remove-compareInBounds` --- ### 📝 Commits (7) - [`9596b06`](https://github.com/microsoft/terminal/commit/9596b06bffe65a2941f6d7a4fcc0dd9ed4d40eb0) Remove most uses of `CompareInBounds` - [`4ce925e`](https://github.com/microsoft/terminal/commit/4ce925ede855923ca78fb88f66d56efe315545ea) address PR comments - [`b105d68`](https://github.com/microsoft/terminal/commit/b105d68a26193058f985be903cd8a884fa8fcc49) clamp to inclusive pos & compare returns 0/1 - [`e9b2ffc`](https://github.com/microsoft/terminal/commit/e9b2ffc4554688a4d5dca9995d27801c09a4b8fe) fix test - [`e0695ec`](https://github.com/microsoft/terminal/commit/e0695ec1404cb1a3f1185cf7bdb625a5a5b32d19) make 'MoveToNextGlyph' prettier - [`49c33d9`](https://github.com/microsoft/terminal/commit/49c33d906bf6f2db737cdf95b551c03faa0adcb2) Merge branch 'main' into dev/cazamor/remove-compareInBounds - [`c98940a`](https://github.com/microsoft/terminal/commit/c98940a95b256e3955877f66eb2891f7070da663) backwards ### 📊 Changes **6 files changed** (+55 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/textBuffer.cpp` (+20 -10) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+3 -3) 📝 `src/interactivity/win32/ut_interactivity_win32/UiaTextRangeTests.cpp` (+2 -2) 📝 `src/types/UiaTextRangeBase.cpp` (+23 -29) 📝 `src/types/inc/viewport.hpp` (+2 -2) 📝 `src/types/viewport.cpp` (+5 -17) </details> ### 📄 Description ## Summary of the Pull Request Replaces most uses of `Viewport::CompareInBounds()` with `til::point`'s `<` and `>` operators. `CompareInBounds` has been the cause of a bunch of UIA crashes over the years. Replacing them entirely ensures that the `FAILFAST_IF` isn't ever touched. Unfortunately, we still need `IncrementInBounds` and `DecrementInBounds` to have support for that exclusive end. ## References #13183 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?