[PR #13258] [MERGED] Hide the use of MIDI behind velocity #29450

Open
opened 2026-01-31 09:34:59 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13258
Author: @DHowett
Created: 6/9/2022
Status: ✅ Merged
Merged: 6/9/2022
Merged by: @DHowett

Base: main ← Head: dev/duhowett/SILENCE,FOOLS


📝 Commits (2)

  • 000b112 Hide the use of MIDI behind velocity
  • a8d7dfb Merge remote-tracking branch 'origin/main' into dev/duhowett/SILENCE,FOOLS

📊 Changes

3 files changed (+27 additions, -5 deletions)

View changed files

📝 src/audio/midi/MidiAudio.cpp (+13 -4)
📝 src/cascadia/TerminalControl/TerminalControlLib.vcxproj (+2 -1)
📝 src/features.xml (+12 -0)

📄 Description

  • conhost requires an additional dependency in Windows, which might
    cause us trouble in WPG
  • Terminal requires an additional package dependency, which will
    cause us trouble in WPG (since GmDls is about 3MB)

I chose to scope the feature checks to MidiOut directly, as I wanted to
keep the delay behavior in MidiAudio::PlayNote. This is negotiable.

References #13252


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13258 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 6/9/2022 **Status:** ✅ Merged **Merged:** 6/9/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/SILENCE,FOOLS` --- ### 📝 Commits (2) - [`000b112`](https://github.com/microsoft/terminal/commit/000b112543f23df9bf6cd5d4c145f0407264d447) Hide the use of MIDI behind velocity - [`a8d7dfb`](https://github.com/microsoft/terminal/commit/a8d7dfb556dfbc48953cb43e38f0efc607784451) Merge remote-tracking branch 'origin/main' into dev/duhowett/SILENCE,FOOLS ### 📊 Changes **3 files changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/audio/midi/MidiAudio.cpp` (+13 -4) 📝 `src/cascadia/TerminalControl/TerminalControlLib.vcxproj` (+2 -1) 📝 `src/features.xml` (+12 -0) </details> ### 📄 Description * conhost requires an additional dependency in Windows, which might cause us trouble in WPG * Terminal requires an additional *package* dependency, which *will* cause us trouble in WPG (since GmDls is about 3MB) I chose to scope the feature checks to MidiOut directly, as I wanted to keep the delay behavior in MidiAudio::PlayNote. This is negotiable. References #13252 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:59 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29450