[PR #13291] [MERGED] Update the scrollbar postiton on scrollToMark #29458

Open
opened 2026-01-31 09:35:03 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13291
Author: @zadjii-msft
Created: 6/13/2022
Status: Merged
Merged: 6/16/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/scrollbar-update-on-scrollToMark


📝 Commits (3)

  • 13d48a9 Update the scrollbar postiton on scrollToMark
  • cd28a8b can I get a spellbot.exe on .git/pre-commit?
  • 246cc9d Update src/cascadia/TerminalControl/ControlCore.cpp

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+8 -0)

📄 Description

When I moved this into ControlCore, I forgot that UserScrollViewport is usually triggered by the scrollbar updating, so it doesn't ask the UI to update. Since this logic is in ControlCore, it's sorta in a weird place where it needs to communicate both up and down:

  • update the Terminal's viewport position
  • update the TermControl's scrollbar position

Checklist:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13291 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/13/2022 **Status:** ✅ Merged **Merged:** 6/16/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/scrollbar-update-on-scrollToMark` --- ### 📝 Commits (3) - [`13d48a9`](https://github.com/microsoft/terminal/commit/13d48a9c00078d8e99bb03121b24ff4d6ac34ce5) Update the scrollbar postiton on `scrollToMark` - [`cd28a8b`](https://github.com/microsoft/terminal/commit/cd28a8b969bfec1338c81f6068ac11076cb4f84c) can I get a spellbot.exe on .git/pre-commit? - [`246cc9d`](https://github.com/microsoft/terminal/commit/246cc9d838c9760e91aa1dea5a4346f02f674454) Update src/cascadia/TerminalControl/ControlCore.cpp ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+8 -0) </details> ### 📄 Description When I moved this into ControlCore, I forgot that UserScrollViewport is usually triggered by the scrollbar updating, so it doesn't ask the UI to update. Since this logic is in ControlCore, it's sorta in a weird place where it needs to communicate both up and down: * update the `Terminal`'s viewport position * update the `TermControl`'s scrollbar position Checklist: * [x] Closes a bug bash bug * [x] Missed in #12948 * See also #11000 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:03 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29458