[PR #13293] [CLOSED] Allow preview connection to take in a preview string to display #29469

Open
opened 2026-01-31 09:35:07 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13293
Author: @PankajBhojwani
Created: 6/13/2022
Status: ❌ Closed

Base: main ← Head: dev/pabhoj/preview_string


📝 Commits (1)

  • b3997a3 preview connection ctor takes preview string

📊 Changes

3 files changed (+10 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp (+3 -4)
📝 src/cascadia/TerminalSettingsEditor/PreviewConnection.h (+4 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.cpp (+3 -1)

📄 Description

Summary of the Pull Request

When only the Profiles->Appearance page was using a preview control, it was okay to have a predefined 'preview' string that the preview control would display. Now that the ColorSchemes page also wants a preview control (to showcase all 16 colors), it makes sense to allow the page that is creating the preview control to decide what the preview string should be. So, the preview connection now takes in a preview string.

References

This is a prerequisite for #13269

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

Profiles->Appearance preview control still works as before


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13293 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/13/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/pabhoj/preview_string` --- ### 📝 Commits (1) - [`b3997a3`](https://github.com/microsoft/terminal/commit/b3997a3dadd72eff23851e6f396159414195632e) preview connection ctor takes preview string ### 📊 Changes **3 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp` (+3 -4) 📝 `src/cascadia/TerminalSettingsEditor/PreviewConnection.h` (+4 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.cpp` (+3 -1) </details> ### 📄 Description ## Summary of the Pull Request When only the Profiles->Appearance page was using a preview control, it was okay to have a predefined 'preview' string that the preview control would display. Now that the ColorSchemes page also wants a preview control (to showcase all 16 colors), it makes sense to allow the page that is creating the preview control to decide what the preview string should be. So, the preview connection now takes in a preview string. ## References This is a prerequisite for #13269 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Profiles->Appearance preview control still works as before --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:07 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29469