starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13343] [MERGED] Re-enable the setting to adjust the colors of indistinguishable text #29487

New Issue
Open
opened 2026-01-31 09:35:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:12 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13343
Author: @PankajBhojwani
Created: 6/20/2022
Status: ✅ Merged
Merged: 7/14/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/delta_e

📝 Commits (9)

📊 Changes

5 files changed (+34 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -1)
📝 src/features.xml (+1 -4)
📝 src/renderer/base/RenderSettings.cpp (+21 -8)
📝 src/renderer/inc/RenderSettings.hpp (+1 -1)
📝 src/terminal/adapter/adaptDispatch.cpp (+10 -0)

📄 Description

Summary of the Pull Request

Re-enable the setting to adjust indistinguishable text, with some changes:

  • We now pre-calculate the nudged values for 'default bright foreground' as well
  • When a color table entry is manually set (i.e. via VT sequences) we re-calculate the nudged values

References

#11095 #12160

PR Checklist

Validation Steps Performed

Indistinguishable text gets adjusted again

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13343 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/20/2022 **Status:** ✅ Merged **Merged:** 7/14/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/delta_e` --- ### 📝 Commits (9) - [`86a7133`](https://github.com/microsoft/terminal/commit/86a71339b86d2e82f717a3badc12bc28cd44b27f) ignore brighten/invisible - [`d86700f`](https://github.com/microsoft/terminal/commit/d86700f786f50430fe609e7407759cdbd76f56c0) enable in feature, default setting is false - [`230c2aa`](https://github.com/microsoft/terminal/commit/230c2aa2f484c7af4bd6e99ad512c2609c32ec84) add comment - [`fa230fb`](https://github.com/microsoft/terminal/commit/fa230fbe4731afa21928d3b5f7e458bcb00a8d73) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/delta_e - [`39ee965`](https://github.com/microsoft/terminal/commit/39ee965eaf8b33cd58ad78c7c0f9f700430776a3) fixes - [`38f3401`](https://github.com/microsoft/terminal/commit/38f34010d29164b21aebaef85cfcb3e45f95d20e) fix comment - [`7a843d7`](https://github.com/microsoft/terminal/commit/7a843d73adff786911637e5fb866653512151010) fix other comment - [`35c8069`](https://github.com/microsoft/terminal/commit/35c80693881a7b7303a595c3193234f48bea76ab) back to default off - [`d69e1be`](https://github.com/microsoft/terminal/commit/d69e1be14404350cfb412d9624a6c151920e1610) assign color ### 📊 Changes **5 files changed** (+34 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -1) 📝 `src/features.xml` (+1 -4) 📝 `src/renderer/base/RenderSettings.cpp` (+21 -8) 📝 `src/renderer/inc/RenderSettings.hpp` (+1 -1) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+10 -0) </details> ### 📄 Description ## Summary of the Pull Request Re-enable the setting to adjust indistinguishable text, with some changes: - We now pre-calculate the nudged values for 'default bright foreground' as well - When a color table entry is manually set (i.e. via VT sequences) we re-calculate the nudged values ## References #11095 #12160 ## PR Checklist * [x] Closes #11917 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. ## Validation Steps Performed Indistinguishable text gets adjusted again --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29487
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?