[PR #13360] [MERGED] [1.14] Fix keyboard selection and copyOnSelect interaction #29507

Open
opened 2026-01-31 09:35:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13360
Author: @carlos-zamora
Created: 6/22/2022
Status: ✅ Merged
Merged: 7/1/2022
Merged by: @DHowett

Base: release-1.14 ← Head: dev/cazamor/1.14/bugfix-copyOnSelect


📝 Commits (4)

  • b0b0a6c [1.14] Fix keyboard selection and copyOnSelect interaction
  • c4f37fc remove const
  • d9cfe31 Merge branch 'release-1.14' into dev/cazamor/1.14/bugfix-copyOnSelect
  • 9dc99a9 Update src/cascadia/TerminalCore/TerminalSelection.cpp

📊 Changes

7 files changed (+46 additions, -12 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+9 -3)
📝 src/cascadia/TerminalControl/ControlCore.h (+2 -1)
📝 src/cascadia/TerminalControl/ControlInteractivity.cpp (+23 -7)
📝 src/cascadia/TerminalControl/ControlInteractivity.h (+2 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+1 -0)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+7 -0)

📄 Description

Summary of the Pull Request

⚠️This targets release-1.14⚠️
Backport of #13358

This PR fixes a number of interactions between copyOnSelect and keyboard selection. Sometimes the selection just wouldn't be cleared or copied appropriately.

I wrote a whole flowchart of expected behavior with copy on select:

  • enable copyOnSelect
    • make a selection with the mouse
      • ✅ right-click should copy the text --> clear the selection --> paste
    • use keyboard selection to quick-edit the existing selection
      • ✅ copy action should clear the selection
      • ✅ right-click should copy the text --> clear the selection --> paste

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13360 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/22/2022 **Status:** ✅ Merged **Merged:** 7/1/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `release-1.14` ← **Head:** `dev/cazamor/1.14/bugfix-copyOnSelect` --- ### 📝 Commits (4) - [`b0b0a6c`](https://github.com/microsoft/terminal/commit/b0b0a6ce4d1c9cdefab88cfd5f395d0496a50754) [1.14] Fix keyboard selection and copyOnSelect interaction - [`c4f37fc`](https://github.com/microsoft/terminal/commit/c4f37fc1d1a03506e920f10b770ce10f5fa698eb) remove const - [`d9cfe31`](https://github.com/microsoft/terminal/commit/d9cfe319c9326b188026e1af6196bc232ac2ac31) Merge branch 'release-1.14' into dev/cazamor/1.14/bugfix-copyOnSelect - [`9dc99a9`](https://github.com/microsoft/terminal/commit/9dc99a91c1d94cb30e64cbbfa75fdf3c4d544bd2) Update src/cascadia/TerminalCore/TerminalSelection.cpp ### 📊 Changes **7 files changed** (+46 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+9 -3) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+2 -1) 📝 `src/cascadia/TerminalControl/ControlInteractivity.cpp` (+23 -7) 📝 `src/cascadia/TerminalControl/ControlInteractivity.h` (+2 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+1 -0) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request ⚠️This targets release-1.14⚠️ Backport of #13358 This PR fixes a number of interactions between `copyOnSelect` and keyboard selection. Sometimes the selection just wouldn't be cleared or copied appropriately. I wrote a whole flowchart of expected behavior with copy on select: - enable `copyOnSelect` - make a selection with the mouse - ✅ right-click should copy the text --> clear the selection --> paste - use keyboard selection to quick-edit the existing selection - ✅ `copy` action should clear the selection - ✅ right-click should copy the text --> clear the selection --> paste --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29507