Opening tab too fast crashes terminal #2951

Closed
opened 2026-01-30 23:09:33 +00:00 by claunia · 3 comments
Owner

Originally created by @SJang1 on GitHub (Jul 26, 2019).

Environment

Windows build number: Microsoft Windows [Version 10.0.18941.1001]
Windows Terminal version (if applicable): commit id c97cccb

Steps to reproduce

Open tab too fast and many of them.
Using shortcut key(default ctrl+shift+number) makes easy to open lots of tab at once

Which I was doing was holding shortcut key(crtl+shift+2 to open cmd) for few seconds.

Expected behavior

Only one tab open or Lots of tabs opens without any problem.

Actual behavior

Terminal crashes (without any error message)

Originally created by @SJang1 on GitHub (Jul 26, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18941.1001] Windows Terminal version (if applicable): commit id c97cccb ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> Open tab too fast and many of them. Using shortcut key(default ctrl+shift+number) makes easy to open lots of tab at once Which I was doing was holding shortcut key(crtl+shift+2 to open cmd) for few seconds. # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> Only one tab open or Lots of tabs opens without any problem. # Actual behavior <!-- What's actually happening? --> Terminal crashes (without any error message)
Author
Owner

@zadjii-msft commented on GitHub (Jul 30, 2019):

The error that appears in the log is "Bad optional access".

My guess is this is secretly related to #2122 (shockingly). It might be already fixed, but I haven't checked on that branch quite yet.

If it's not already fixed, then it could be an exception on any of the Pane's optionals, it could be the profile optionals like 2122 was, or it could even theoretically be the _cursorTimer in TermControl. All of those were spots we were investigating for the previous bug.

@zadjii-msft commented on GitHub (Jul 30, 2019): The error that appears in the log is "Bad optional access". My guess is this is secretly related to #2122 (shockingly). It might be already fixed, but I haven't checked on that branch quite yet. If it's not already fixed, then it could be an exception on any of the Pane's `optional`s, it could be the profile `optional`s like 2122 was, or it could even theoretically be the `_cursorTimer` in `TermControl`. All of those were spots we were investigating for the previous bug.
Author
Owner

@SJang1 commented on GitHub (Jul 30, 2019):

It seems to fixed crashing, but made another bug :
image

image
(with tabTitle as cmd)

clicking on a tab and clicking in the console makes "only that" tab name to be shown like as normal.

@SJang1 commented on GitHub (Jul 30, 2019): It seems to fixed crashing, but made another bug : ![image](https://user-images.githubusercontent.com/29011440/62143582-34a98000-b32b-11e9-9c47-6d5ef494a2a6.png) ![image](https://user-images.githubusercontent.com/29011440/62143745-91a53600-b32b-11e9-8a53-2346e22324df.png) (with tabTitle as cmd) clicking on a tab and clicking in the console makes "only that" tab name to be shown like as normal.
Author
Owner

@SJang1 commented on GitHub (Jul 30, 2019):

I'll make it as a new issue. This bug seems to be fixed. Thanks!

@SJang1 commented on GitHub (Jul 30, 2019): I'll make it as a new issue. This bug seems to be fixed. Thanks!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2951