starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13362] [MERGED] Add support for soft fonts in the DX renderer #29510

New Issue
Open
opened 2026-01-31 09:35:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:21 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13362
Author: @j4james
Created: 6/23/2022
Status: ✅ Merged
Merged: 7/14/2022
Merged by: @undefined

Base: main ← Head: dx-soft-fonts

📝 Commits (4)

  • 6f3a049 Add support for soft fonts in the DX renderer.
  • a66a2ce Add to spelling-bot dictionary.
  • 30b59be Don't die on reset.
  • 20ab8c2 Switch bitmap format to R8_UNORM.

📊 Changes

10 files changed (+384 additions, -14 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+2 -0)
📝 src/renderer/dx/CustomTextRenderer.cpp (+7 -7)
📝 src/renderer/dx/CustomTextRenderer.h (+5 -0)
📝 src/renderer/dx/DxRenderer.cpp (+47 -7)
📝 src/renderer/dx/DxRenderer.hpp (+7 -0)
➕ src/renderer/dx/DxSoftFont.cpp (+256 -0)
➕ src/renderer/dx/DxSoftFont.h (+55 -0)
📝 src/renderer/dx/lib/dx.vcxproj (+2 -0)
📝 src/renderer/dx/lib/dx.vcxproj.filters (+2 -0)
📝 src/renderer/dx/sources.inc (+1 -0)

📄 Description

Summary of the Pull Request

This PR adds support for downloadable soft fonts in the DirectX
renderer, potentially enabling them to be used in Windows Terminal.

References

Soft fonts were first implemented in conhost (with the GDI renderer) in
PR #10011.

PR Checklist

  • Closes #xxx
  • CLA signed.
  • Tests added/passed
  • Documentation updated.
  • Schema updated.
  • I've discussed this with core contributors already. If not
    checked, I'm ready to accept this work might be rejected in favor of a
    different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

The way the DirectX implementation works is by building up a bitmap
containing all of the glyphs, and then drawing an appropriate subsection
of that bitmap for each character that needs to be rendered. The current
text color is applied with a color matrix effect, and the glyphs are
automatically scaled up to the current font size with a scaling effect.

By default the scaling uses a high quality cubic interpolation, which
gives it a smoother antialiased effect. But if the Text antialiasing
option is configured as Aliased, we use a simpler nearest-neighbor
interpolation, which more closely matches the rendering of the original
GDI implementation.

Validation Steps Performed

I've manually tested the renderer in conhost with the UseDx registry
entry. I've also tested in Windows Terminal using the experimental
passthrough mode.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13362 **Author:** [@j4james](https://github.com/j4james) **Created:** 6/23/2022 **Status:** ✅ Merged **Merged:** 7/14/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dx-soft-fonts` --- ### 📝 Commits (4) - [`6f3a049`](https://github.com/microsoft/terminal/commit/6f3a049c183d78b046dec0f752b74d3f5aa7bdbf) Add support for soft fonts in the DX renderer. - [`a66a2ce`](https://github.com/microsoft/terminal/commit/a66a2cee7b7ff12e4844c6d43734f9709c9213f1) Add to spelling-bot dictionary. - [`30b59be`](https://github.com/microsoft/terminal/commit/30b59be0c26f29d656eee2662c5fa62de1c5b573) Don't die on reset. - [`20ab8c2`](https://github.com/microsoft/terminal/commit/20ab8c2b9c09ab4daa20bd7241facd0ceb1590e0) Switch bitmap format to R8_UNORM. ### 📊 Changes **10 files changed** (+384 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+2 -0) 📝 `src/renderer/dx/CustomTextRenderer.cpp` (+7 -7) 📝 `src/renderer/dx/CustomTextRenderer.h` (+5 -0) 📝 `src/renderer/dx/DxRenderer.cpp` (+47 -7) 📝 `src/renderer/dx/DxRenderer.hpp` (+7 -0) ➕ `src/renderer/dx/DxSoftFont.cpp` (+256 -0) ➕ `src/renderer/dx/DxSoftFont.h` (+55 -0) 📝 `src/renderer/dx/lib/dx.vcxproj` (+2 -0) 📝 `src/renderer/dx/lib/dx.vcxproj.filters` (+2 -0) 📝 `src/renderer/dx/sources.inc` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request This PR adds support for downloadable soft fonts in the DirectX renderer, potentially enabling them to be used in Windows Terminal. ## References Soft fonts were first implemented in conhost (with the GDI renderer) in PR #10011. ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments The way the DirectX implementation works is by building up a bitmap containing all of the glyphs, and then drawing an appropriate subsection of that bitmap for each character that needs to be rendered. The current text color is applied with a color matrix effect, and the glyphs are automatically scaled up to the current font size with a scaling effect. By default the scaling uses a high quality cubic interpolation, which gives it a smoother antialiased effect. But if the *Text antialiasing* option is configured as *Aliased*, we use a simpler nearest-neighbor interpolation, which more closely matches the rendering of the original GDI implementation. ## Validation Steps Performed I've manually tested the renderer in conhost with the `UseDx` registry entry. I've also tested in Windows Terminal using the experimental passthrough mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?