[PR #13360] [1.14] Fix keyboard selection and copyOnSelect interaction #29512

Open
opened 2026-01-31 09:35:21 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13360

State: closed
Merged: Yes


Summary of the Pull Request

⚠️This targets release-1.14⚠️
Backport of #13358

This PR fixes a number of interactions between copyOnSelect and keyboard selection. Sometimes the selection just wouldn't be cleared or copied appropriately.

I wrote a whole flowchart of expected behavior with copy on select:

  • enable copyOnSelect
    • make a selection with the mouse
      • ✅ right-click should copy the text --> clear the selection --> paste
    • use keyboard selection to quick-edit the existing selection
      • ✅ copy action should clear the selection
      • ✅ right-click should copy the text --> clear the selection --> paste
**Original Pull Request:** https://github.com/microsoft/terminal/pull/13360 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request ⚠️This targets release-1.14⚠️ Backport of #13358 This PR fixes a number of interactions between `copyOnSelect` and keyboard selection. Sometimes the selection just wouldn't be cleared or copied appropriately. I wrote a whole flowchart of expected behavior with copy on select: - enable `copyOnSelect` - make a selection with the mouse - ✅ right-click should copy the text --> clear the selection --> paste - use keyboard selection to quick-edit the existing selection - ✅ `copy` action should clear the selection - ✅ right-click should copy the text --> clear the selection --> paste
claunia added the pull-request label 2026-01-31 09:35:21 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29512