starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13390] [MERGED] Implement MVVM for the GlobalAppearance page #29516

New Issue
Open
opened 2026-01-31 09:35:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13390
Author: @PankajBhojwani
Created: 6/27/2022
Status: ✅ Merged
Merged: 7/8/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/mvvm_appearance

📝 Commits (9)

📊 Changes

12 files changed (+393 additions, -314 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp (+2 -233)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.h (+2 -36)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.idl (+2 -19)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+17 -17)
➕ src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.cpp (+262 -0)
➕ src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.h (+60 -0)
➕ src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.idl (+36 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+9 -0)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+1 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.h (+0 -6)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl (+0 -2)

📄 Description

Summary of the Pull Request

Implements a GlobalAppearanceViewModel for the GlobalAppearance page in the SUI

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Global appearance page still works

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13390 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/27/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/mvvm_appearance` --- ### 📝 Commits (9) - [`a6eb488`](https://github.com/microsoft/terminal/commit/a6eb48858d7b661822e207c89a5ede886f480cf3) initial - [`bdaf64e`](https://github.com/microsoft/terminal/commit/bdaf64e21f73b705bf8f770b916cd2e514de30de) mvvm - [`6645b8d`](https://github.com/microsoft/terminal/commit/6645b8dd80518b8f121cc900325481f69f3186b4) conflict - [`e5017eb`](https://github.com/microsoft/terminal/commit/e5017eb6ad109aee6c2b76f821bc7e5131686b90) helping - [`e355eb9`](https://github.com/microsoft/terminal/commit/e355eb91575e54ed4c12b135d94c56613ff4b6ef) no more ref to model in xaml - [`1891c92`](https://github.com/microsoft/terminal/commit/1891c922ee0b54cec8dfd3af97ac70d49c5051a7) dont expose model - [`6d41a61`](https://github.com/microsoft/terminal/commit/6d41a61cb26c259fe7cb7d017987bc808e41b7cb) format - [`53dae88`](https://github.com/microsoft/terminal/commit/53dae88570c3224c44c158fd90169396c03676e7) Merge branch 'dev/pabhoj/mvvm_appearance' of https://github.com/microsoft/terminal into dev/pabhoj/mvvm_appearance - [`5dc79f9`](https://github.com/microsoft/terminal/commit/5dc79f938b59a0eacd002cb9e6d38e87230f5ab9) conflict ### 📊 Changes **12 files changed** (+393 additions, -314 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp` (+2 -233) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.h` (+2 -36) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.idl` (+2 -19) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+17 -17) ➕ `src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.cpp` (+262 -0) ➕ `src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.h` (+60 -0) ➕ `src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.idl` (+36 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+9 -0) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.h` (+0 -6) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl` (+0 -2) </details> ### 📄 Description ## Summary of the Pull Request Implements a `GlobalAppearanceViewModel` for the GlobalAppearance page in the SUI ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Global appearance page still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?