[PR #13377] [MERGED] Implement MVVM for the Launch page #29518

Open
opened 2026-01-31 09:35:24 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13377
Author: @PankajBhojwani
Created: 6/24/2022
Status: ✅ Merged
Merged: 7/8/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/sui_mvvm


📝 Commits (4)

📊 Changes

10 files changed (+156 additions, -97 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Launch.cpp (+1 -44)
📝 src/cascadia/TerminalSettingsEditor/Launch.h (+2 -19)
📝 src/cascadia/TerminalSettingsEditor/Launch.idl (+2 -20)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+13 -13)
➕ src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp (+65 -0)
➕ src/cascadia/TerminalSettingsEditor/LaunchViewModel.h (+34 -0)
➕ src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl (+27 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+9 -0)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+1 -0)

📄 Description

Summary of the Pull Request

Implements a LaunchViewModel for the Launch page in the SUI

PR Checklist

  • CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

Launch page still works


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13377 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/24/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/sui_mvvm` --- ### 📝 Commits (4) - [`7033afd`](https://github.com/microsoft/terminal/commit/7033afd990fe89d087cd137b5684c388692142a7) initial boilerplate - [`dee16b2`](https://github.com/microsoft/terminal/commit/dee16b21ce9bdbaf89273dac6c0182c362048e8a) commit before deleeting a bunch - [`a26589e`](https://github.com/microsoft/terminal/commit/a26589e31afeea2e578554171a11bd88b6722b5d) deleted - [`449bb2b`](https://github.com/microsoft/terminal/commit/449bb2bd47d357e125fde8d7ad24fedf3c03981c) nits ### 📊 Changes **10 files changed** (+156 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Launch.cpp` (+1 -44) 📝 `src/cascadia/TerminalSettingsEditor/Launch.h` (+2 -19) 📝 `src/cascadia/TerminalSettingsEditor/Launch.idl` (+2 -20) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+13 -13) ➕ `src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp` (+65 -0) ➕ `src/cascadia/TerminalSettingsEditor/LaunchViewModel.h` (+34 -0) ➕ `src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl` (+27 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+9 -0) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Implements a `LaunchViewModel` for the Launch page in the SUI ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Launch page still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:24 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29518