[PR #13391] [MERGED] Implement MVVM for the Rendering page #29530

Open
opened 2026-01-31 09:35:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13391
Author: @PankajBhojwani
Created: 6/27/2022
Status: Merged
Merged: 7/8/2022
Merged by: @undefined

Base: mainHead: dev/pabhoj/mvvm_rendering


📝 Commits (5)

📊 Changes

10 files changed (+82 additions, -22 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+9 -0)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Rendering.cpp (+1 -2)
📝 src/cascadia/TerminalSettingsEditor/Rendering.h (+2 -11)
📝 src/cascadia/TerminalSettingsEditor/Rendering.idl (+3 -6)
📝 src/cascadia/TerminalSettingsEditor/Rendering.xaml (+2 -2)
src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp (+17 -0)
src/cascadia/TerminalSettingsEditor/RenderingViewModel.h (+28 -0)
src/cascadia/TerminalSettingsEditor/RenderingViewModel.idl (+17 -0)

📄 Description

Summary of the Pull Request

Implements a RenderingViewModel for the Rendering page in the SUI

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Rendering page still works


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13391 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/27/2022 **Status:** ✅ Merged **Merged:** 7/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/mvvm_rendering` --- ### 📝 Commits (5) - [`4fdee49`](https://github.com/microsoft/terminal/commit/4fdee49235cc713367a6333dd84e74eb4e43df80) rendering mvvm - [`1257660`](https://github.com/microsoft/terminal/commit/125766062a73aef587b8abe54512c402f8e60a11) remove include - [`1ab51bf`](https://github.com/microsoft/terminal/commit/1ab51bf9e968b2ef98d3f0498af9d3c748144b7d) nits - [`6777fb8`](https://github.com/microsoft/terminal/commit/6777fb893907f314ff6a359d5c3380535820e712) fix - [`e86f475`](https://github.com/microsoft/terminal/commit/e86f475b64ef53154c4224bc6e3f4c3107e72d86) conflict ### 📊 Changes **10 files changed** (+82 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+9 -0) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.cpp` (+1 -2) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.h` (+2 -11) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.idl` (+3 -6) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.xaml` (+2 -2) ➕ `src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp` (+17 -0) ➕ `src/cascadia/TerminalSettingsEditor/RenderingViewModel.h` (+28 -0) ➕ `src/cascadia/TerminalSettingsEditor/RenderingViewModel.idl` (+17 -0) </details> ### 📄 Description ## Summary of the Pull Request Implements a `RenderingViewModel` for the Rendering page in the SUI ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Rendering page still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29530