[PR #13465] [MERGED] A pile of Theming nits fixes #29557

Open
opened 2026-01-31 09:35:37 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13465
Author: @zadjii-msft
Created: 7/8/2022
Status: ✅ Merged
Merged: 7/12/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/13456-themes-nits-000


📝 Commits (8)

  • 55fcefa a lot of nits
  • 85560fc fix the propertychanged and the MMCC colors
  • b9d96d0 a bit cleaner
  • 980732b Merge remote-tracking branch 'origin/main' into dev/migrie/b/13456-themes-nits-000
  • d70052b now isn't that clever
  • 6a2b290 Merge remote-tracking branch 'origin/main' into dev/migrie/b/13456-themes-nits-000
  • 38db4ee runformat
  • 1c6d3a4 get rid of appplytheme

📊 Changes

13 files changed (+104 additions, -65 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp (+9 -4)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+8 -13)
📝 src/cascadia/TerminalApp/AppLogic.h (+6 -3)
📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+17 -20)
📝 src/cascadia/TerminalApp/TitlebarControl.cpp (+43 -0)
📝 src/cascadia/TerminalApp/TitlebarControl.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+6 -2)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+8 -5)
📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+0 -15)
📝 src/cascadia/TerminalSettingsModel/Theme.h (+1 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+2 -1)
📝 src/cascadia/WindowsTerminal/AppHost.h (+1 -1)

📄 Description

The main fix here is for the caption button colors. If you had a dark OS/app theme, and a light titlebar, we'd end up with light glyphs, so the caption buttons would be impossible to find.

There's also a pile of nits from #12992 in here. Probably enough to close #13456 out, but I'll let Dustin be the judge.

Filing today, to get in for 1.16 selfhost (@DHowett)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13465 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/8/2022 **Status:** ✅ Merged **Merged:** 7/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/13456-themes-nits-000` --- ### 📝 Commits (8) - [`55fcefa`](https://github.com/microsoft/terminal/commit/55fcefa6cecfdd676df6619dd2a3cecbb57c4538) a lot of nits - [`85560fc`](https://github.com/microsoft/terminal/commit/85560fc06af131113813f3fd8e71d54dd2f4029d) fix the propertychanged and the MMCC colors - [`b9d96d0`](https://github.com/microsoft/terminal/commit/b9d96d0d35b28f526bcf3a0f862bc20e8199b4fa) a bit cleaner - [`980732b`](https://github.com/microsoft/terminal/commit/980732b9b0c8bebb7e8524d77368e17fdff844b1) Merge remote-tracking branch 'origin/main' into dev/migrie/b/13456-themes-nits-000 - [`d70052b`](https://github.com/microsoft/terminal/commit/d70052b53ff7b4d69ba0a50b132667184de2104a) now isn't that clever - [`6a2b290`](https://github.com/microsoft/terminal/commit/6a2b29076a787e43085e8dcecc3546ce88c35cf5) Merge remote-tracking branch 'origin/main' into dev/migrie/b/13456-themes-nits-000 - [`38db4ee`](https://github.com/microsoft/terminal/commit/38db4ee1e7137e2109dd7d2e08af096c319ad1ab) runformat - [`1c6d3a4`](https://github.com/microsoft/terminal/commit/1c6d3a4e034d035456cd6e4818feff1cae0a82b9) get rid of appplytheme ### 📊 Changes **13 files changed** (+104 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp` (+9 -4) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+8 -13) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+6 -3) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+17 -20) 📝 `src/cascadia/TerminalApp/TitlebarControl.cpp` (+43 -0) 📝 `src/cascadia/TerminalApp/TitlebarControl.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+6 -2) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+8 -5) 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+0 -15) 📝 `src/cascadia/TerminalSettingsModel/Theme.h` (+1 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+2 -1) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+1 -1) </details> ### 📄 Description The main fix here is for the caption button colors. If you had a dark OS/app theme, and a light titlebar, we'd end up with light glyphs, so the caption buttons would be impossible to find. There's also a pile of nits from #12992 in here. Probably enough to close #13456 out, but I'll let Dustin be the judge. Filing today, to get in for 1.16 selfhost (@DHowett) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29557