[PR #13462] [CLOSED] Always flush conpty before passing-thru a sequence we didn't understand #29559

Open
opened 2026-01-31 09:35:38 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13462
Author: @zadjii-msft
Created: 7/8/2022
Status: Closed

Base: mainHead: dev/migrie/b/8698-YOURE-OUT-OF-ORDER


📝 Commits (6)

📊 Changes

17 files changed (+1170 additions, -854 deletions)

View changed files

.github/actions/spelling/README.md (+15 -0)
📝 .github/actions/spelling/advice.md (+16 -18)
📝 .github/actions/spelling/allow/allow.txt (+10 -2)
📝 .github/actions/spelling/allow/apis.txt (+15 -3)
📝 .github/actions/spelling/allow/names.txt (+2 -0)
.github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+39 -6)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -8)
📝 .github/actions/spelling/expect/expect.txt (+127 -755)
📝 .github/actions/spelling/expect/web.txt (+0 -23)
.github/actions/spelling/line_forbidden.patterns (+62 -0)
📝 .github/actions/spelling/patterns/patterns.txt (+73 -0)
📝 .github/actions/spelling/reject.txt (+9 -19)
📝 .github/workflows/spelling2.yml (+123 -9)
📝 src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp (+115 -3)
📝 src/host/screenInfo.cpp (+13 -1)
📝 src/terminal/adapter/adaptDispatch.cpp (+28 -7)

📄 Description

I'll fill this out in a bit


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13462 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/8/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/migrie/b/8698-YOURE-OUT-OF-ORDER` --- ### 📝 Commits (6) - [`e5fbc1b`](https://github.com/microsoft/terminal/commit/e5fbc1bb11fc100c2f191bdc08e48501213decfe) https://i.giphy.com/media/eGJgwDXbKP6nK/source.gif - [`502d197`](https://github.com/microsoft/terminal/commit/502d197fd8c98276888fd1733d353a47906bb15f) Add a comment - [`7e8bb9e`](https://github.com/microsoft/terminal/commit/7e8bb9e3c4c32f1be0491ed391c1597e1feb36fa) get rid of the manual flushs - [`f194402`](https://github.com/microsoft/terminal/commit/f1944022ee702ad14a0177f7bd769c7c7d26c1cf) Merge remote-tracking branch 'origin/main' into dev/migrie/b/8698-YOURE-OUT-OF-ORDER - [`3e40ee1`](https://github.com/microsoft/terminal/commit/3e40ee1458eb5002a7047f42463ec86d49aa479f) working on some bad ideas. This broke ConptyRoundtripTests::PassthroughHardReset - [`3a44967`](https://github.com/microsoft/terminal/commit/3a44967dcf7b4ad0d9024f046de6d60b0006ba00) Migrate spelling-0.0.21 changes from main ### 📊 Changes **17 files changed** (+1170 additions, -854 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spelling/README.md` (+15 -0) 📝 `.github/actions/spelling/advice.md` (+16 -18) 📝 `.github/actions/spelling/allow/allow.txt` (+10 -2) 📝 `.github/actions/spelling/allow/apis.txt` (+15 -3) 📝 `.github/actions/spelling/allow/names.txt` (+2 -0) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+39 -6) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -8) 📝 `.github/actions/spelling/expect/expect.txt` (+127 -755) 📝 `.github/actions/spelling/expect/web.txt` (+0 -23) ➕ `.github/actions/spelling/line_forbidden.patterns` (+62 -0) 📝 `.github/actions/spelling/patterns/patterns.txt` (+73 -0) 📝 `.github/actions/spelling/reject.txt` (+9 -19) 📝 `.github/workflows/spelling2.yml` (+123 -9) 📝 `src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp` (+115 -3) 📝 `src/host/screenInfo.cpp` (+13 -1) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+28 -7) </details> ### 📄 Description I'll fill this out in a bit * [ ] Closes #8698 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29559