[PR #13467] [MERGED] Improve Launch MVVM #29560

Open
opened 2026-01-31 09:35:38 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13467
Author: @PankajBhojwani
Created: 7/8/2022
Status: ✅ Merged
Merged: 7/26/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/fix_launch_mvvm


📝 Commits (2)

📊 Changes

4 files changed (+42 additions, -18 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+5 -5)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp (+18 -7)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.h (+9 -2)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl (+10 -4)

📄 Description

Summary of the Pull Request

The xaml file no longer directly accesses the settings model object, and the settings model object is no longer exposed on the view model

References

#13377

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Still works


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13467 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/8/2022 **Status:** ✅ Merged **Merged:** 7/26/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/fix_launch_mvvm` --- ### 📝 Commits (2) - [`81c2f48`](https://github.com/microsoft/terminal/commit/81c2f48db6f2f98692a9a51f56c344d4d9954728) fix - [`6493c3e`](https://github.com/microsoft/terminal/commit/6493c3eb499c474ee0f203b3e01ff553371667a2) fix return type ### 📊 Changes **4 files changed** (+42 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+5 -5) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp` (+18 -7) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.h` (+9 -2) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl` (+10 -4) </details> ### 📄 Description ## Summary of the Pull Request The xaml file no longer directly accesses the settings model object, and the settings model object is no longer exposed on the view model ## References #13377 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29560