[PR #13483] [MERGED] Send focus events even in ReadOnly mode #29578

Open
opened 2026-01-31 09:35:43 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13483
Author: @zadjii-msft
Created: 7/11/2022
Status: Merged
Merged: 7/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/13461-readonly-focus


📝 Commits (3)

  • 49f0d98 this is dumb but it works
  • c38e687 he's technically correct, the best kind of correct
  • 2996fd9 that'll happen working in multiple clones at once

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+13 -2)
📝 src/cascadia/TerminalControl/ControlCore.h (+1 -0)

📄 Description

Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13483 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/11/2022 **Status:** ✅ Merged **Merged:** 7/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/13461-readonly-focus` --- ### 📝 Commits (3) - [`49f0d98`](https://github.com/microsoft/terminal/commit/49f0d98bfee40d0c8acec690a0367b410abfbda1) this is dumb but it works - [`c38e687`](https://github.com/microsoft/terminal/commit/c38e687dd6792546996bc399fb4e9048c56589e1) he's technically correct, the best kind of correct - [`2996fd9`](https://github.com/microsoft/terminal/commit/2996fd97758b63f11e2014bc611713d754c2adce) that'll happen working in multiple clones at once ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+13 -2) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+1 -0) </details> ### 📄 Description Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection. * closes #13461 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:43 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29578