starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13494] [MERGED] [Follow-up] Polish keyboard navigation to hyperlinks #29590

New Issue
Open
opened 2026-01-31 09:35:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13494
Author: @carlos-zamora
Created: 7/13/2022
Status: ✅ Merged
Merged: 8/25/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/polish-tab-to-link

📝 Commits (5)

  • e0806be [Follow-up] Polish keyboard navigation to hyperlinks
  • 26d1deb rebind 'enter' as kbd
  • a493944 Merge branch 'main' into dev/cazamor/polish-tab-to-link
  • 1acf0d4 code format
  • 57b1dab Merge branch 'main' into dev/cazamor/polish-tab-to-link

📊 Changes

5 files changed (+56 additions, -24 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+42 -13)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -2)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+10 -8)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+1 -0)

📄 Description

Summary of the Pull Request

Polishes #13405 with some additional feedback found in testing and post-mortem reviews. Such feedback includes:

  • ControlInteractivity vs ControlCore split (link)
  • clearing the selection should be under lock when copying text via "Enter"
  • move mark mode keybindings into a helper function
  • decide if "Enter" should be configurable or non-configurable (link)
  • rename _isTargetingUrl
  • bugfix: ctrl+enter when the link is outside of the viewport

References

Original PR: #13405
Relevant issue: #6649
Epic: #4993

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13494 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 7/13/2022 **Status:** ✅ Merged **Merged:** 8/25/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/polish-tab-to-link` --- ### 📝 Commits (5) - [`e0806be`](https://github.com/microsoft/terminal/commit/e0806beb7e4ef541668512d7788e2298578501b1) [Follow-up] Polish keyboard navigation to hyperlinks - [`26d1deb`](https://github.com/microsoft/terminal/commit/26d1deb3982102957b0836d7f56ea03eeb8930db) rebind 'enter' as kbd - [`a493944`](https://github.com/microsoft/terminal/commit/a4939448ead99adc9fd15a9580a116c316aec2cf) Merge branch 'main' into dev/cazamor/polish-tab-to-link - [`1acf0d4`](https://github.com/microsoft/terminal/commit/1acf0d47a7177e2694feba802cbbc7c32043bd09) code format - [`57b1dab`](https://github.com/microsoft/terminal/commit/57b1dabf53d70c583ab9d18b856f4ddfec4d90d8) Merge branch 'main' into dev/cazamor/polish-tab-to-link ### 📊 Changes **5 files changed** (+56 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+42 -13) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -2) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+10 -8) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Polishes #13405 with some additional feedback found in testing and post-mortem reviews. Such feedback includes: - [x] ControlInteractivity vs ControlCore split ([link](https://github.com/microsoft/terminal/pull/13405#discussion_r919365435)) - [x] clearing the selection should be under lock when copying text via "Enter" - [x] move mark mode keybindings into a helper function - [x] decide if "Enter" should be configurable or non-configurable ([link](https://github.com/microsoft/terminal/pull/13405#discussion_r919379305)) - [x] rename `_isTargetingUrl` - [x] bugfix: ctrl+enter when the link is outside of the viewport ## References Original PR: #13405 Relevant issue: #6649 Epic: #4993 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29590
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?