[PR #13493] Fix a bad null deref #29591

Open
opened 2026-01-31 09:35:47 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13493

State: closed
Merged: Yes


Yep this is my bad. I was trying to fix a bug where only having one of background or unfocusedBackground would cause the other to never get set to the default. In attempting to force all the logic into an if statement, I messed up the order of operations. My bad 😢

Regressed in #13456

**Original Pull Request:** https://github.com/microsoft/terminal/pull/13493 **State:** closed **Merged:** Yes --- Yep this is my bad. I was trying to fix a bug where only having one of `background` or `unfocusedBackground` would cause the other to never get set to the default. In attempting to force all the logic into an if statement, I messed up the order of operations. My bad 😢 Regressed in #13456
claunia added the pull-request label 2026-01-31 09:35:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29591