starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13512] [MERGED] Change AdjustIndistinguishableColors to an enum setting instead of a boolean setting #29599

New Issue
Open
opened 2026-01-31 09:35:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13512
Author: @PankajBhojwani
Created: 7/14/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/delta_e_further

📝 Commits (10+)

📊 Changes

19 files changed (+118 additions, -17 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+16 -4)
📝 src/cascadia/TerminalCore/ICoreAppearance.idl (+8 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+16 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+6 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+4 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+5 -2)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+12 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl (+1 -1)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+28 -0)
📝 src/cascadia/inc/ControlProperties.h (+1 -1)
📝 src/renderer/base/RenderSettings.cpp (+11 -1)
📝 src/renderer/inc/RenderSettings.hpp (+2 -1)
📝 src/terminal/adapter/adaptDispatch.cpp (+2 -2)

📄 Description

Summary of the Pull Request

AdjustIndistinguishableColors can now be set to:

  • Never: Never adjust the colors
  • Indexed: Only adjust colors that are part of the color scheme
  • Always: Always adjust the colors

References

#13343

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

For legacy purposes, true and false map to Indexed and Never respectively

Validation Steps Performed

Setting still works

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13512 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/14/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/delta_e_further` --- ### 📝 Commits (10+) - [`86a7133`](https://github.com/microsoft/terminal/commit/86a71339b86d2e82f717a3badc12bc28cd44b27f) ignore brighten/invisible - [`d86700f`](https://github.com/microsoft/terminal/commit/d86700f786f50430fe609e7407759cdbd76f56c0) enable in feature, default setting is false - [`230c2aa`](https://github.com/microsoft/terminal/commit/230c2aa2f484c7af4bd6e99ad512c2609c32ec84) add comment - [`c4b0fb2`](https://github.com/microsoft/terminal/commit/c4b0fb2f5b2e5855ffd0327bc00e56e23ff7dee5) setting is in - [`4c7c187`](https://github.com/microsoft/terminal/commit/4c7c187f4378936ed34097f631e93a93ff3e90b0) implement - [`332f8b6`](https://github.com/microsoft/terminal/commit/332f8b603dd43fdb71aa564a9a28d6f98a89005f) conflict - [`bde0937`](https://github.com/microsoft/terminal/commit/bde09374b47eb0ab19e8977a68cf6167dcf18a91) legacy mappings - [`da5116a`](https://github.com/microsoft/terminal/commit/da5116a7bcd6252bdd814d4fe3cca01f48d0b707) string fixes - [`4be97c8`](https://github.com/microsoft/terminal/commit/4be97c85b5cec0883ed8e2f9713a59bc231c6229) mapping fixes - [`bd48da0`](https://github.com/microsoft/terminal/commit/bd48da03bd840f57bcb5c9ad58567013b8baccbd) don't break concealed ### 📊 Changes **19 files changed** (+118 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+16 -4) 📝 `src/cascadia/TerminalCore/ICoreAppearance.idl` (+8 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+16 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+6 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+4 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+5 -2) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+12 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+28 -0) 📝 `src/cascadia/inc/ControlProperties.h` (+1 -1) 📝 `src/renderer/base/RenderSettings.cpp` (+11 -1) 📝 `src/renderer/inc/RenderSettings.hpp` (+2 -1) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+2 -2) </details> ### 📄 Description ## Summary of the Pull Request `AdjustIndistinguishableColors` can now be set to: - `Never`: Never adjust the colors - `Indexed`: Only adjust colors that are part of the color scheme - `Always`: Always adjust the colors ## References #13343 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments For legacy purposes, `true` and `false` map to `Indexed` and `Never` respectively ## Validation Steps Performed Setting still works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?