[PR #13505] Fix bad code in fuzzing_directed.h #29601

Open
opened 2026-01-31 09:35:50 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13505

State: closed
Merged: Yes


2b202ce6 changed this code to fix 2-phase name lookup, but accidentally
changed &m_tInit to &CFuzzType::m_tInit (pointer-to-member¹)
instead of &this->m_tInit (a regular pointer to some value).
This should not be confused with &(CFuzzType::m_tInit)
of course which is not a pointer-to-member.

¹ To simplify things, a pointer-to-member is basically the byte offset of a
member within a struct. For instance given struct T { char a, b, c, d; } then
&T::c would commonly "store" the value 2, equivalent to offsetof(T, c).

Closes #13501

**Original Pull Request:** https://github.com/microsoft/terminal/pull/13505 **State:** closed **Merged:** Yes --- 2b202ce6 changed this code to fix 2-phase name lookup, but accidentally changed `&m_tInit` to `&CFuzzType::m_tInit` (pointer-to-member¹) instead of `&this->m_tInit` (a regular pointer to some value). This should not be confused with `&(CFuzzType::m_tInit)` of course which is _not_ a pointer-to-member. ¹ To simplify things, a pointer-to-member is basically the byte offset of a member within a struct. For instance given `struct T { char a, b, c, d; }` then `&T::c` would commonly "store" the value 2, equivalent to `offsetof(T, c)`. Closes #13501
claunia added the pull-request label 2026-01-31 09:35:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29601