starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13535] [MERGED] Make ToolsVersion more consistent in our project files #29619

New Issue
Open
opened 2026-01-31 09:35:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:35:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13535
Author: @lhecker
Created: 7/18/2022
Status: ✅ Merged
Merged: 7/26/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/tools-version

📝 Commits (1)

  • a809583 Make ToolsVersion more consistent in our project files

📊 Changes

117 files changed (+217 additions, -220 deletions)

View changed files

📝 build/pgo/Terminal.PGO.DB.nuspec (+1 -1)
📝 build/rules/Branding.targets (+1 -1)
📝 build/rules/CollectWildcardResources.targets (+1 -1)
📝 build/rules/GenerateFeatureFlags.proj (+1 -1)
📝 build/rules/GenerateSxsManifestsFromWinmds.targets (+1 -1)
📝 common.openconsole.props (+1 -1)
📝 custom.props (+1 -1)
📝 doc/feature_flags.md (+1 -1)
📝 samples/ConPTY/EchoCon/EchoCon/EchoCon.vcxproj (+1 -1)
📝 samples/ConPTY/GUIConsole/GUIConsole.WPF/GUIConsole.WPF.csproj (+1 -1)
📝 samples/ConPTY/MiniTerm/MiniTerm/MiniTerm.csproj (+1 -1)
📝 scratch/ScratchIslandApp/Package/Package.wapproj (+1 -1)
📝 scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj (+1 -1)
📝 scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj (+1 -1)
📝 scratch/ScratchIslandApp/WindowExe/WindowExe.vcxproj (+1 -1)
📝 src/StaticAnalysis.ruleset (+5 -7)
📝 src/audio/midi/lib/midi.vcxproj (+1 -1)
📝 src/buffer/out/lib/bufferout.vcxproj (+1 -1)
📝 src/buffer/out/ut_textbuffer/TextBuffer.Unit.Tests.vcxproj (+1 -1)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+1 -1)

...and 80 more files

📄 Description

While working on another PR related to this I noticed that my VS
generates .vcxproj files that are a bit different to the ones we have.
This commit is a quick search & replace of all our project files to make
(primarily) their ToolsVersion more in line with what VS does itself:
No ToolsVersion for .vcxproj, ToolsVersion="15.0"
for .csproj and ToolsVersion="4.0" for .filters files.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13535 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 7/18/2022 **Status:** ✅ Merged **Merged:** 7/26/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/tools-version` --- ### 📝 Commits (1) - [`a809583`](https://github.com/microsoft/terminal/commit/a8095837519c13a9f7698edd0a286f3602537701) Make ToolsVersion more consistent in our project files ### 📊 Changes **117 files changed** (+217 additions, -220 deletions) <details> <summary>View changed files</summary> 📝 `build/pgo/Terminal.PGO.DB.nuspec` (+1 -1) 📝 `build/rules/Branding.targets` (+1 -1) 📝 `build/rules/CollectWildcardResources.targets` (+1 -1) 📝 `build/rules/GenerateFeatureFlags.proj` (+1 -1) 📝 `build/rules/GenerateSxsManifestsFromWinmds.targets` (+1 -1) 📝 `common.openconsole.props` (+1 -1) 📝 `custom.props` (+1 -1) 📝 `doc/feature_flags.md` (+1 -1) 📝 `samples/ConPTY/EchoCon/EchoCon/EchoCon.vcxproj` (+1 -1) 📝 `samples/ConPTY/GUIConsole/GUIConsole.WPF/GUIConsole.WPF.csproj` (+1 -1) 📝 `samples/ConPTY/MiniTerm/MiniTerm/MiniTerm.csproj` (+1 -1) 📝 `scratch/ScratchIslandApp/Package/Package.wapproj` (+1 -1) 📝 `scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj` (+1 -1) 📝 `scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj` (+1 -1) 📝 `scratch/ScratchIslandApp/WindowExe/WindowExe.vcxproj` (+1 -1) 📝 `src/StaticAnalysis.ruleset` (+5 -7) 📝 `src/audio/midi/lib/midi.vcxproj` (+1 -1) 📝 `src/buffer/out/lib/bufferout.vcxproj` (+1 -1) 📝 `src/buffer/out/ut_textbuffer/TextBuffer.Unit.Tests.vcxproj` (+1 -1) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+1 -1) _...and 80 more files_ </details> ### 📄 Description While working on another PR related to this I noticed that my VS generates `.vcxproj` files that are a bit different to the ones we have. This commit is a quick search & replace of all our project files to make (primarily) their `ToolsVersion` more in line with what VS does itself: No `ToolsVersion` for `.vcxproj`, `ToolsVersion="15.0"` for `.csproj` and `ToolsVersion="4.0"` for `.filters` files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:35:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?