starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13565] [MERGED] Upgrade check-spelling to v0.0.20 #29629

New Issue
Open
opened 2026-01-31 09:36:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13565
Author: @jsoref
Created: 7/22/2022
Status: ✅ Merged
Merged: 7/22/2022
Merged by: @zadjii-msft

Base: main ← Head: main-spelling-0.0.20

📝 Commits (7)

📊 Changes

28 files changed (+179 additions, -226 deletions)

View changed files

➕ .github/actions/spelling/README.md (+14 -0)
📝 .github/actions/spelling/advice.md (+16 -18)
📝 .github/actions/spelling/excludes.txt (+18 -1)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -1)
📝 .github/actions/spelling/expect/expect.txt (+13 -155)
📝 .github/actions/spelling/expect/web.txt (+0 -21)
➕ .github/actions/spelling/line_forbidden.patterns (+36 -0)
📝 .github/actions/spelling/patterns/patterns.txt (+18 -0)
📝 .github/actions/spelling/reject.txt (+10 -1)
📝 .github/workflows/spelling2.yml (+34 -8)
📝 README.md (+1 -1)
📝 doc/specs/#1790 - Font features and axes-spec.md (+1 -1)
📝 doc/specs/#492 - Default Terminal/spec.md (+1 -1)
📝 doc/specs/#754 - Cascading Default Settings.md (+1 -1)
📝 doc/specs/#885 - Terminal Settings Model/Actions Addendum.md (+1 -1)
📝 doc/specs/TerminalSettings-spec.md (+1 -1)
📝 doc/specs/drafts/#3327 - Application Theming/#10509 - Mica.md (+1 -1)
📝 doc/specs/drafts/#3327 - Application Theming/#3327 - Application Theming.md (+1 -2)
📝 doc/specs/drafts/576-ProfilesJumplistSpec.md (+1 -1)
📝 src/audio/midi/MidiAudio.cpp (+1 -1)

...and 8 more files

📄 Description

Upgrade check-spelling to v0.0.20

This upgrade includes a refresh of the workflow

key new features:

  • the previous comment is collapsed
  • duplicate words are flagged (see alone and the)
  • forbidding patterns (see nonexistent, preexisting, and greater than)

Each of these features can be tuned

  • comment collapsing is controlled by the followup bits in the workflow-- but I can't imagine why one would want to turn it off
  • duplicate words can be masked in patterns.txt (see Guid and that)
  • forbidding patterns (especially duplicates) is in .github/actions/spelling/line_forbidden.patterns

Fwiw, I'm slowly moving towards not using .txt in filenames, but it's a long term project and I have a bunch of other goals for the near term.

The refresh of advice is of course flexible -- I'm still evolving my default text. Note that the default now includes some curl and I'm still working on how I want to consume the output. I'm getting close to the point where I might be able to provide a tool that could reliably consume the output (including on Windows).

This code has been used internally for a while, but I tested it for this repository here:
https://github.com/check-spelling/terminal/pull/2

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13565 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 7/22/2022 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `main-spelling-0.0.20` --- ### 📝 Commits (7) - [`b70acc3`](https://github.com/microsoft/terminal/commit/b70acc31affaa53f71e922b36abd0847a5af1085) spelling: alone - [`96ad59f`](https://github.com/microsoft/terminal/commit/96ad59f6b155d4c8d8df1ce587fd74f7ec9d04b6) spelling: dependent - [`00443a1`](https://github.com/microsoft/terminal/commit/00443a1c8fccda814b625654a39b59bc11418070) spelling: nonexistent - [`f23e776`](https://github.com/microsoft/terminal/commit/f23e776047673364becb664b18c7390d5ae4f5fc) spelling: preexisting - [`47bcfb5`](https://github.com/microsoft/terminal/commit/47bcfb5b24a3a3da36634ecfc81550ebc5a036b1) spelling: than - [`274d508`](https://github.com/microsoft/terminal/commit/274d508dff6d407265a583ad887f53efc81c6289) spelling: the - [`8495246`](https://github.com/microsoft/terminal/commit/8495246c53661395e8e90a267b13856395accbcd) Upgrade check-spelling to v0.0.20 ### 📊 Changes **28 files changed** (+179 additions, -226 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spelling/README.md` (+14 -0) 📝 `.github/actions/spelling/advice.md` (+16 -18) 📝 `.github/actions/spelling/excludes.txt` (+18 -1) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -1) 📝 `.github/actions/spelling/expect/expect.txt` (+13 -155) 📝 `.github/actions/spelling/expect/web.txt` (+0 -21) ➕ `.github/actions/spelling/line_forbidden.patterns` (+36 -0) 📝 `.github/actions/spelling/patterns/patterns.txt` (+18 -0) 📝 `.github/actions/spelling/reject.txt` (+10 -1) 📝 `.github/workflows/spelling2.yml` (+34 -8) 📝 `README.md` (+1 -1) 📝 `doc/specs/#1790 - Font features and axes-spec.md` (+1 -1) 📝 `doc/specs/#492 - Default Terminal/spec.md` (+1 -1) 📝 `doc/specs/#754 - Cascading Default Settings.md` (+1 -1) 📝 `doc/specs/#885 - Terminal Settings Model/Actions Addendum.md` (+1 -1) 📝 `doc/specs/TerminalSettings-spec.md` (+1 -1) 📝 `doc/specs/drafts/#3327 - Application Theming/#10509 - Mica.md` (+1 -1) 📝 `doc/specs/drafts/#3327 - Application Theming/#3327 - Application Theming.md` (+1 -2) 📝 `doc/specs/drafts/576-ProfilesJumplistSpec.md` (+1 -1) 📝 `src/audio/midi/MidiAudio.cpp` (+1 -1) _...and 8 more files_ </details> ### 📄 Description Upgrade check-spelling to [v0.0.20](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.20) This upgrade includes a refresh of the workflow key new features: * the previous comment is collapsed * duplicate words are flagged (see `alone` and `the`) * forbidding patterns (see `nonexistent`, `preexisting`, and `greater than`) Each of these features can be tuned - comment collapsing is controlled by the `followup` bits in the workflow-- but I can't imagine why one would want to turn it off - duplicate words can be masked in `patterns.txt` (see `Guid` and `that`) - forbidding patterns (especially duplicates) is in `.github/actions/spelling/line_forbidden.patterns` Fwiw, I'm slowly moving towards not using `.txt` in filenames, but it's a long term project and I have a bunch of other goals for the near term. The refresh of advice is of course flexible -- I'm still evolving my default text. Note that the default now includes some `curl` and I'm still working on how I want to consume the output. I'm getting close to the point where I might be able to provide a tool that could reliably consume the output (including on Windows). This code has been used internally for a while, but I tested it for this repository here: https://github.com/check-spelling/terminal/pull/2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?