[PR #13552] Add a pivot to the tab color picker #29631

Open
opened 2026-01-31 09:36:00 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13552

State: closed
Merged: No


Summary of the Pull Request

The "Custom" button on the color picker is a bit strange (at least with regards to accessibility). It's a magical toggle button that reveals/hides content but doesn't interact with the formerly existing content. Instead, I've added a Pivot control to introduce two "modes": "Standard" and "Custom". This aligns with the experience on MS Word's color selection for text.

With regards to accessibility, the role of the "Custom button" won't matter anymore because it won't exist.

While I was here, I also added did a little bit of code cleanup by sprinkling a few const around and removing some unnecessary XAML code.

Additionally, the "Reset" button was renamed to be more descriptive and be able to close #12044.

References

Closes #12045
Closes #12044

Validation Steps Performed

  • color picker works
  • acceptable keyboard navigation on the color picker
**Original Pull Request:** https://github.com/microsoft/terminal/pull/13552 **State:** closed **Merged:** No --- ## Summary of the Pull Request The "Custom" button on the color picker is a bit strange (at least with regards to accessibility). It's a magical toggle button that reveals/hides content but doesn't interact with the formerly existing content. Instead, I've added a Pivot control to introduce two "modes": "Standard" and "Custom". This aligns with the experience on MS Word's color selection for text. With regards to accessibility, the role of the "Custom button" won't matter anymore because it won't exist. While I was here, I also added did a little bit of code cleanup by sprinkling a few `const` around and removing some unnecessary XAML code. Additionally, the "Reset" button was renamed to be more descriptive and be able to close #12044. ## References Closes #12045 Closes #12044 ## Validation Steps Performed - color picker works - acceptable keyboard navigation on the color picker
claunia added the pull-request label 2026-01-31 09:36:00 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29631