[PR #13570] [MERGED] Wire up passing LNK/EXE data from OpenCon to ITerminalHandoff #29636

Open
opened 2026-01-31 09:36:03 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13570
Author: @zadjii-msft
Created: 7/22/2022
Status: Merged
Merged: 8/26/2022
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/f/9458-startupInfoToTerminal


📝 Commits (10+)

  • 103beb4 I just want to run the scratch project, I have no idea how this got so brboken
  • c795793 Revert "I just want to run the scratch project, I have no idea how this got so brboken"
  • 11bfc73 A BLANK SCRATCH COMMIT
  • 1dd6e99 prototype
  • 874a15b Good-news-everyone.gif
  • dc78b32 this does temporarily get the title out of the link, but then it's lose
  • 9a2ee6a Cleanup, comments, etc.
  • fd75c5e I think this is all the prototyping I need
  • 4b717db Merge remote-tracking branch 'origin/main' into dev/migrie/f/9458-startupInfoToTerminal
  • c0b4840 Merge remote-tracking branch 'origin/main' into dev/migrie/f/9458-startupInfoToTerminal

📊 Changes

20 files changed (+253 additions, -44 deletions)

View changed files

📝 scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj (+12 -5)
📝 scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj (+15 -3)
📝 scratch/ScratchIslandApp/WindowExe/SampleIslandWindow.cpp (+0 -2)
📝 scratch/ScratchIslandApp/WindowExe/WindowExe.vcxproj (+23 -10)
📝 src/cascadia/CascadiaPackage/Package-Dev.appxmanifest (+2 -1)
📝 src/cascadia/CascadiaPackage/Package-Pre.appxmanifest (+2 -1)
📝 src/cascadia/CascadiaPackage/Package.appxmanifest (+2 -1)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -0)
📝 src/cascadia/TerminalConnection/CTerminalHandoff.cpp (+2 -2)
📝 src/cascadia/TerminalConnection/CTerminalHandoff.h (+4 -3)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+15 -3)
📝 src/cascadia/TerminalConnection/ConptyConnection.h (+14 -2)
📝 src/cascadia/TerminalConnection/ConptyConnection.idl (+1 -0)
📝 src/host/proxy/ITerminalHandoff.idl (+44 -0)
📝 src/host/srvinit.cpp (+79 -3)
📝 src/interactivity/inc/ISystemConfigurationProvider.hpp (+8 -1)
📝 src/interactivity/onecore/SystemConfigurationProvider.cpp (+2 -1)
📝 src/interactivity/onecore/SystemConfigurationProvider.hpp (+2 -1)
📝 src/interactivity/win32/SystemConfigurationProvider.cpp (+23 -4)
📝 src/interactivity/win32/SystemConfigurationProvider.hpp (+2 -1)

📄 Description

This PR by itself doesn't really change much. Technically, now the Terminal will respect the Title of a .lnk when started for defterm, but we don't do anything else yet. Primarily, the goal of this PR is to just wire up startup info in OpenConsole to the connected Terminal.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13570 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 8/26/2022 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/f/9458-startupInfoToTerminal` --- ### 📝 Commits (10+) - [`103beb4`](https://github.com/microsoft/terminal/commit/103beb4be156d138cce09df2f355304cae526641) I just want to run the scratch project, I have no idea how this got so brboken - [`c795793`](https://github.com/microsoft/terminal/commit/c795793f4c966142a40b1bff47ec5ae4f831fb5f) Revert "I just want to run the scratch project, I have no idea how this got so brboken" - [`11bfc73`](https://github.com/microsoft/terminal/commit/11bfc7340058dd2665415d7e500e9803cb1fda2f) A BLANK SCRATCH COMMIT - [`1dd6e99`](https://github.com/microsoft/terminal/commit/1dd6e993401042e318f43a4240804e731cde520e) prototype - [`874a15b`](https://github.com/microsoft/terminal/commit/874a15b89bf88ac071531bf41b4e6c94a09f80d2) Good-news-everyone.gif - [`dc78b32`](https://github.com/microsoft/terminal/commit/dc78b3267aa56bc77ff0db632579f3f7ba68a9f4) this does temporarily get the title out of the link, but then it's lose - [`9a2ee6a`](https://github.com/microsoft/terminal/commit/9a2ee6a7c29c6bb4c25314acf0e8993594cfbca9) Cleanup, comments, etc. - [`fd75c5e`](https://github.com/microsoft/terminal/commit/fd75c5e1ea6545682f4d10f3c56e5912a51cb7f9) I think this is all the prototyping I need - [`4b717db`](https://github.com/microsoft/terminal/commit/4b717db6f0d3685bcd9ee0dab84189553af3757f) Merge remote-tracking branch 'origin/main' into dev/migrie/f/9458-startupInfoToTerminal - [`c0b4840`](https://github.com/microsoft/terminal/commit/c0b4840dcd204c94896960e5e3f7b97210ee9d49) Merge remote-tracking branch 'origin/main' into dev/migrie/f/9458-startupInfoToTerminal ### 📊 Changes **20 files changed** (+253 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `scratch/ScratchIslandApp/SampleApp/SampleAppLib.vcxproj` (+12 -5) 📝 `scratch/ScratchIslandApp/SampleApp/dll/SampleApp.vcxproj` (+15 -3) 📝 `scratch/ScratchIslandApp/WindowExe/SampleIslandWindow.cpp` (+0 -2) 📝 `scratch/ScratchIslandApp/WindowExe/WindowExe.vcxproj` (+23 -10) 📝 `src/cascadia/CascadiaPackage/Package-Dev.appxmanifest` (+2 -1) 📝 `src/cascadia/CascadiaPackage/Package-Pre.appxmanifest` (+2 -1) 📝 `src/cascadia/CascadiaPackage/Package.appxmanifest` (+2 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -0) 📝 `src/cascadia/TerminalConnection/CTerminalHandoff.cpp` (+2 -2) 📝 `src/cascadia/TerminalConnection/CTerminalHandoff.h` (+4 -3) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+15 -3) 📝 `src/cascadia/TerminalConnection/ConptyConnection.h` (+14 -2) 📝 `src/cascadia/TerminalConnection/ConptyConnection.idl` (+1 -0) 📝 `src/host/proxy/ITerminalHandoff.idl` (+44 -0) 📝 `src/host/srvinit.cpp` (+79 -3) 📝 `src/interactivity/inc/ISystemConfigurationProvider.hpp` (+8 -1) 📝 `src/interactivity/onecore/SystemConfigurationProvider.cpp` (+2 -1) 📝 `src/interactivity/onecore/SystemConfigurationProvider.hpp` (+2 -1) 📝 `src/interactivity/win32/SystemConfigurationProvider.cpp` (+23 -4) 📝 `src/interactivity/win32/SystemConfigurationProvider.hpp` (+2 -1) </details> ### 📄 Description This PR by itself doesn't _really_ change much. Technically, now the Terminal will respect the Title of a `.lnk` when started for defterm, but we don't do anything else yet. Primarily, the goal of this PR is to just wire up startup info in OpenConsole to the connected Terminal. * This required a bit of changes in `srvinit.cpp:ConsoleEstablishHandoff` to replicate other bits of startup, where we crack open the connect message to get the relevant bits of info. * We pack that all into a `TERMINAL_STARTUP_INFO`, which we pass along to the registered terminal application. * `ConptyConnection` accepts the handoff, and gathers that information out of the `TERMINAL_STARTUP_INFO` * Some other updates to the scratch sln were made to make it build again (related, but unimportant). * This is a precursor to: * #13111 * #12154 * Closes #9458 * Tested manually * I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:03 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29636