[PR #13604] [MERGED] Hopefully fix the HandleCommandlineArgs crashes #29645

Open
opened 2026-01-31 09:36:07 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13604
Author: @zadjii-msft
Created: 7/26/2022
Status: ✅ Merged
Merged: 7/29/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/11790-july-2022


📝 Commits (8)

  • a53dc65 Hopefully fix the HandleCommandlineArgs crashes
  • e0c5bb4 sure, spel
  • a3cc917 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11790-july-2022
  • 9c3f958 This is unrelated, but might be why we were seeing those intermittent crashes when dtoring a renderer
  • f14cd00 limit the number of retries
  • ada8b5d I'll show you who DNE
  • 228cd72 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11790-july-2022
  • 1081029 spel? solated? :squint:

📊 Changes

4 files changed (+95 additions, -78 deletions)

View changed files

📝 .github/actions/spelling/allow/apis.txt (+1 -0)
📝 OpenConsole.sln (+19 -18)
📝 src/cascadia/Remoting/WindowManager.cpp (+73 -60)
📝 src/cascadia/Remoting/WindowManager.h (+2 -0)

📄 Description

This is an experiment, as discussed in https://github.com/microsoft/terminal/issues/11790#issuecomment-1179143049. We don't know what for sure causes these crashes, but it seems that blindly throwing, so that it gets picked up by Watson, is probably not the move. Instead, we're just gonna do our fallback, REGARDLESS of what the exception was.

See #11790, MSFT:38542548, MSFT:38572983, MSFT:38542574 et. al.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13604 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/26/2022 **Status:** ✅ Merged **Merged:** 7/29/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11790-july-2022` --- ### 📝 Commits (8) - [`a53dc65`](https://github.com/microsoft/terminal/commit/a53dc659c536e48ca523992a9dbc2f25a7d40b8f) Hopefully fix the HandleCommandlineArgs crashes - [`e0c5bb4`](https://github.com/microsoft/terminal/commit/e0c5bb40c1356c601c4abe98849386aa7ad060c8) sure, spel - [`a3cc917`](https://github.com/microsoft/terminal/commit/a3cc91785dd58f43f056265c1dcbf3890cc75c45) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11790-july-2022 - [`9c3f958`](https://github.com/microsoft/terminal/commit/9c3f95883c233afd756eddb6ea06e7236c93046a) This is unrelated, but might be why we were seeing those intermittent crashes when dtoring a renderer - [`f14cd00`](https://github.com/microsoft/terminal/commit/f14cd00452fc748d4eb365ce88ab5cb2e667e084) limit the number of retries - [`ada8b5d`](https://github.com/microsoft/terminal/commit/ada8b5d0aefef81bda6c2b5846e1d420ea487d99) I'll show you who DNE - [`228cd72`](https://github.com/microsoft/terminal/commit/228cd72fc35b0d59c4b14c1f19e947074daa90e3) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11790-july-2022 - [`1081029`](https://github.com/microsoft/terminal/commit/1081029eb9e2420316741c97a294673ba757829c) spel? solated? :squint: ### 📊 Changes **4 files changed** (+95 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/apis.txt` (+1 -0) 📝 `OpenConsole.sln` (+19 -18) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+73 -60) 📝 `src/cascadia/Remoting/WindowManager.h` (+2 -0) </details> ### 📄 Description This is an experiment, as discussed in https://github.com/microsoft/terminal/issues/11790#issuecomment-1179143049. We don't know what for sure causes these crashes, but it seems that blindly throwing, so that it gets picked up by Watson, is probably not the move. Instead, we're just gonna do our fallback, REGARDLESS of what the exception was. See #11790, MSFT:38542548, MSFT:38572983, MSFT:38542574 et. al. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:07 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29645