[PR #13605] [MERGED] Implement InitialPosition and CenterOnLaunch in the SUI #29646

Open
opened 2026-01-31 09:36:07 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13605
Author: @PankajBhojwani
Created: 7/26/2022
Status: ✅ Merged
Merged: 10/5/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/dxd_sui


📝 Commits (10+)

📊 Changes

7 files changed (+295 additions, -12 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Launch.cpp (+11 -0)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+62 -11)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp (+116 -0)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.h (+18 -1)
📝 src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl (+6 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+80 -0)

📄 Description

Summary of the Pull Request

InitialPosition and CenterOnLaunch can now be edited in the SUI

PR Checklist

  • Closes Ctrl+C doen't stop a program in windows terminal powershell console. (#9075)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

InitialPosition follows the same style as LaunchSize, with a number box for the x coordinate and a number box for the y coordinate. When there is no value for either of these coordinates, the respective number box is empty (and displays the text Undefined).

Validation Steps Performed

They work


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13605 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/26/2022 **Status:** ✅ Merged **Merged:** 10/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/dxd_sui` --- ### 📝 Commits (10+) - [`ade1658`](https://github.com/microsoft/terminal/commit/ade1658cf25d8d5992f45c7ef85adfe91d0cdb66) launch position - [`e7fbb44`](https://github.com/microsoft/terminal/commit/e7fbb4410ee3c74c64e1afaf5e0c041fcd49230a) center on launch - [`265bff2`](https://github.com/microsoft/terminal/commit/265bff25dda92e63142133401cc2605a88c949fa) dictionary - [`02ba2c0`](https://github.com/microsoft/terminal/commit/02ba2c02263d6e9e599d5ed87e8cc54a39326192) conflict - [`364b692`](https://github.com/microsoft/terminal/commit/364b692641fa972e15f5c6ed6f48736c35f00782) stylistic fixes - [`ee19ae3`](https://github.com/microsoft/terminal/commit/ee19ae390c9bdc97e7452645f54f11aeb84ef5f5) const - [`04fe18d`](https://github.com/microsoft/terminal/commit/04fe18d975acf001d040293ca6a8678751dbdf80) format, resource strings - [`b87bea8`](https://github.com/microsoft/terminal/commit/b87bea89eaac6771e0e7d89ff98256fa065bf1ec) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/dxd_sui - [`1ee23e9`](https://github.com/microsoft/terminal/commit/1ee23e9293e714314f33ad19a063ceb45f4d6154) Everything works except the current value - [`7067cb4`](https://github.com/microsoft/terminal/commit/7067cb4aeadfdfe90afc28a83d19550bb0ab4d9d) works ### 📊 Changes **7 files changed** (+295 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Launch.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+62 -11) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.cpp` (+116 -0) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.h` (+18 -1) 📝 `src/cascadia/TerminalSettingsEditor/LaunchViewModel.idl` (+6 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+80 -0) </details> ### 📄 Description ## Summary of the Pull Request `InitialPosition` and `CenterOnLaunch` can now be edited in the SUI ## PR Checklist * [x] Closes #9075 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments `InitialPosition` follows the same style as `LaunchSize`, with a number box for the x coordinate and a number box for the y coordinate. When there is no value for either of these coordinates, the respective number box is empty (and displays the text `Undefined`). ## Validation Steps Performed They work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:07 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29646