starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13603] [MERGED] Two sets of localtest fixes for July 2022 #29648

New Issue
Open
opened 2026-01-31 09:36:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13603
Author: @zadjii-msft
Created: 7/26/2022
Status: ✅ Merged
Merged: 7/27/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/localtests-jul-2022

📝 Commits (7)

📊 Changes

2 files changed (+24 additions, -3 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp (+10 -3)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+14 -0)

📄 Description

Cleans up a couple local test failures.

  • Closes #13474: So, I clearly hadn't ran the local tests at the end of the themes PR. We needed a sensible fallback to SOME theme, even if there wasn't one provided in the user json. This is only really hit in the tests (that don't also include defaults.json.
  • Closes #13323: Meh, the ordering of the keys in this test doesn't matter. Ordering is a map implementation detail. This is fine.
  • Ran tests locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13603 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/26/2022 **Status:** ✅ Merged **Merged:** 7/27/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/localtests-jul-2022` --- ### 📝 Commits (7) - [`2dacc1b`](https://github.com/microsoft/terminal/commit/2dacc1b1f0c4f45f425c19ad1cdec13da02b315e) this fixes #13474 - [`33c75f1`](https://github.com/microsoft/terminal/commit/33c75f13b569a96130e334a65d4e3efb6d05133e) okay, that should have been in the parent. Whatever - [`802056f`](https://github.com/microsoft/terminal/commit/802056f69352504b8c3a25189db3b759ec730ceb) this fixes #13323 - [`641748a`](https://github.com/microsoft/terminal/commit/641748a4c4e25cb4d69b60a249184fb1f3d5ab1f) one last one - [`a46e2a3`](https://github.com/microsoft/terminal/commit/a46e2a36f72d24e4de6024cbe28a5dcee126eb30) spel - [`1b3ee16`](https://github.com/microsoft/terminal/commit/1b3ee16579b77d90481e7da6e484091349cda80e) Merge remote-tracking branch 'origin/main' into dev/migrie/b/localtests-jul-2022 - [`4e8975d`](https://github.com/microsoft/terminal/commit/4e8975d2f746d968feaef2e3975d9e913731f5bc) This comment is reworded for clarity ### 📊 Changes **2 files changed** (+24 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/SerializationTests.cpp` (+10 -3) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+14 -0) </details> ### 📄 Description Cleans up a couple local test failures. * [x] Closes #13474: So, I clearly hadn't ran the local tests at the end of the themes PR. We needed a sensible fallback to SOME theme, even if there wasn't one provided in the user json. This is only really hit in the tests (that don't also include `defaults.json`. * [x] Closes #13323: Meh, the ordering of the keys in this test doesn't matter. Ordering is a map implementation detail. This is fine. * [x] Ran tests locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29648
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?