[PR #13602] [MERGED] Rename newTabPosition values #29649

Open
opened 2026-01-31 09:36:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13602
Author: @serd2011
Created: 7/26/2022
Status: Merged
Merged: 7/26/2022
Merged by: @undefined

Base: mainHead: 13597


📝 Commits (2)

📊 Changes

5 files changed (+18 additions, -19 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -6)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+10 -10)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl (+1 -1)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+1 -1)

📄 Description

Renames newTabPosition strings and enums.
Also fixes the schema, noted in https://github.com/microsoft/terminal/pull/13469#discussion_r928138496

Closes #13597


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13602 **Author:** [@serd2011](https://github.com/serd2011) **Created:** 7/26/2022 **Status:** ✅ Merged **Merged:** 7/26/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `13597` --- ### 📝 Commits (2) - [`8c0402a`](https://github.com/microsoft/terminal/commit/8c0402a1199b20d3aa31157a242cfa758f7a8d05) Renamed newTabPosition strings - [`e6ec299`](https://github.com/microsoft/terminal/commit/e6ec299abfea381d14d80baa9ff586681014b1ae) fix formating ### 📊 Changes **5 files changed** (+18 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -6) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+10 -10) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+1 -1) </details> ### 📄 Description Renames `newTabPosition` strings and enums. Also fixes the schema, noted in https://github.com/microsoft/terminal/pull/13469#discussion_r928138496 Closes #13597 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29649