[PR #13604] Hopefully fix the HandleCommandlineArgs crashes #29650

Open
opened 2026-01-31 09:36:08 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13604

State: closed
Merged: Yes


This is an experiment, as discussed in https://github.com/microsoft/terminal/issues/11790#issuecomment-1179143049. We don't know what for sure causes these crashes, but it seems that blindly throwing, so that it gets picked up by Watson, is probably not the move. Instead, we're just gonna do our fallback, REGARDLESS of what the exception was.

See #11790, MSFT:38542548, MSFT:38572983, MSFT:38542574 et. al.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/13604 **State:** closed **Merged:** Yes --- This is an experiment, as discussed in https://github.com/microsoft/terminal/issues/11790#issuecomment-1179143049. We don't know what for sure causes these crashes, but it seems that blindly throwing, so that it gets picked up by Watson, is probably not the move. Instead, we're just gonna do our fallback, REGARDLESS of what the exception was. See #11790, MSFT:38542548, MSFT:38572983, MSFT:38542574 et. al.
claunia added the pull-request label 2026-01-31 09:36:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29650