[PR #13646] Fix a couple of issues with color scheme MVVM #29681

Open
opened 2026-01-31 09:36:17 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/13646

State: closed
Merged: Yes


Summary of the Pull Request

  • When 'discard changes' is hit, we re-initialize our list of color scheme view models but forgot to tell xaml about it, this commit fixes that.
  • Make sure to exit rename mode when 'update settings' gets called

References

color schemes mvvm added in #13179

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Hitting discard changes doesn't cause an inconsistency with the currently selected scheme anymore

**Original Pull Request:** https://github.com/microsoft/terminal/pull/13646 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request - When 'discard changes' is hit, we re-initialize our list of color scheme view models but forgot to tell xaml about it, this commit fixes that. - Make sure to exit rename mode when 'update settings' gets called ## References color schemes mvvm added in #13179 ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Hitting discard changes doesn't cause an inconsistency with the currently selected scheme anymore
claunia added the pull-request label 2026-01-31 09:36:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29681