starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13659] [MERGED] Make Mark Mode keybindings precede custom keybindings #29685

New Issue
Open
opened 2026-01-31 09:36:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:19 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13659
Author: @carlos-zamora
Created: 8/2/2022
Status: ✅ Merged
Merged: 8/22/2022
Merged by: @undefined

Base: main ← Head: dev/cazamor/mark-mode/mamo-precedes-kbd

📝 Commits (3)

  • 7047e56 Make Mark Mode keybindings precede custom keybindings
  • d980227 helper method!
  • b640544 move TryMarkModeKbd() into TryHandleKbd()

📊 Changes

4 files changed (+90 additions, -59 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+67 -47)
📝 src/cascadia/TerminalControl/ControlCore.h (+3 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+9 -11)
📝 src/cascadia/TerminalControl/TermControl.cpp (+11 -1)

📄 Description

Summary of the Pull Request

This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted.

References

Epic: #4993
Closes #13533

Validation Steps Performed

  • Add custom keybinding to "down" arrow key
  • in mark mode --> selection updates appropriately
  • out of mark mode --> keybinding executed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13659 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 8/2/2022 **Status:** ✅ Merged **Merged:** 8/22/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/mark-mode/mamo-precedes-kbd` --- ### 📝 Commits (3) - [`7047e56`](https://github.com/microsoft/terminal/commit/7047e562035fb64f4d10f8d39eb2423c00c95fe4) Make Mark Mode keybindings precede custom keybindings - [`d980227`](https://github.com/microsoft/terminal/commit/d980227ac010c504503b227b26f41feb11774db1) helper method! - [`b640544`](https://github.com/microsoft/terminal/commit/b6405446c1be408fecf16987e0e901ffce2236b9) move TryMarkModeKbd() into TryHandleKbd() ### 📊 Changes **4 files changed** (+90 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+67 -47) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+3 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+9 -11) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+11 -1) </details> ### 📄 Description ## Summary of the Pull Request This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted. ## References Epic: #4993 Closes #13533 ## Validation Steps Performed - Add custom keybinding to "down" arrow key - in mark mode --> selection updates appropriately - out of mark mode --> keybinding executed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29685
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?