[PR #13688] [MERGED] Replace result codes with exceptions in JumpList #29708

Open
opened 2026-01-31 09:36:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13688
Author: @lhecker
Created: 8/5/2022
Status: Merged
Merged: 8/8/2022
Merged by: @undefined

Base: mainHead: dev/lhecker/5907-jumplist


📝 Commits (1)

📊 Changes

2 files changed (+31 additions, -48 deletions)

View changed files

📝 src/cascadia/TerminalApp/Jumplist.cpp (+29 -46)
📝 src/cascadia/TerminalApp/Jumplist.h (+2 -2)

📄 Description

This commit simplifies Jumplist::UpdateJumplist by using exceptions
instead of returning error codes. Otherwise the code is identical to before.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13688 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/5/2022 **Status:** ✅ Merged **Merged:** 8/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/5907-jumplist` --- ### 📝 Commits (1) - [`f9dd951`](https://github.com/microsoft/terminal/commit/f9dd951fc32dc4e8b0470e7eec89f55468f12c58) JumpList code cleanup ### 📊 Changes **2 files changed** (+31 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Jumplist.cpp` (+29 -46) 📝 `src/cascadia/TerminalApp/Jumplist.h` (+2 -2) </details> ### 📄 Description This commit simplifies `Jumplist::UpdateJumplist` by using exceptions instead of returning error codes. Otherwise the code is identical to before. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29708