starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13707] [MERGED] Flash the pane dark when BEL is emitted in a light terminal #29726

New Issue
Open
opened 2026-01-31 09:36:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13707
Author: @Fyrebright
Created: 8/9/2022
Status: ✅ Merged
Merged: 8/11/2022
Merged by: @undefined

Base: main ← Head: bug/13450-dark-bel-flash

📝 Commits (4)

  • 5146332 add light color check and dark version of animation
  • 27df1e1 remove unnecessary float
  • 01fb4b6 apply suggestions from code review
  • 2c0c69c Spellbot + reword comment

📊 Changes

4 files changed (+39 additions, -5 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+33 -4)
📝 src/cascadia/TerminalControl/TermControl.h (+4 -0)
📝 src/cascadia/TerminalControl/XamlLights.cpp (+1 -1)

📄 Description

Adds a variable _isBackgroundLight that is updated when the background
color is changed. When it is true, the BEL indicator flash will darken
the screen instead of brightening.

_isColorLight(bg) returns true if the average of r, g, and b
is >127

I was unsure of an appropriate way to change the color of the
CompositionLight based on the background, so I changed it to always be
gray and adjusted the intensity values of the original animation to have
roughly the same visual effect as the white.

Validation Steps Performed

  • Tested the two flashes on the default color schemes and some custom
    background colors to see if they look consistent
  • Used tracepoints and visual to check that the right animation is used
    (including multiple tabs, split windows with different themes, and
    changing settings while window is open)

References #9270
Closes #13450

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13707 **Author:** [@Fyrebright](https://github.com/Fyrebright) **Created:** 8/9/2022 **Status:** ✅ Merged **Merged:** 8/11/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `bug/13450-dark-bel-flash` --- ### 📝 Commits (4) - [`5146332`](https://github.com/microsoft/terminal/commit/514633269d281386fbccf88858da2a4fb71a3664) add light color check and dark version of animation - [`27df1e1`](https://github.com/microsoft/terminal/commit/27df1e134df523aab1901e07f9fd190a5c0a99fa) remove unnecessary float - [`01fb4b6`](https://github.com/microsoft/terminal/commit/01fb4b688d11c718776eaa9d54b3e14bb37b9ab6) apply suggestions from code review - [`2c0c69c`](https://github.com/microsoft/terminal/commit/2c0c69cc7d18e78acea28e7c9567e1bc6fd31620) Spellbot + reword comment ### 📊 Changes **4 files changed** (+39 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+33 -4) 📝 `src/cascadia/TerminalControl/TermControl.h` (+4 -0) 📝 `src/cascadia/TerminalControl/XamlLights.cpp` (+1 -1) </details> ### 📄 Description Adds a variable `_isBackgroundLight` that is updated when the background color is changed. When it is `true`, the BEL indicator flash will darken the screen instead of brightening. `_isColorLight(bg)` returns `true` if the average of `r`, `g`, and `b` is >127 I was unsure of an appropriate way to change the color of the `CompositionLight` based on the background, so I changed it to always be gray and adjusted the intensity values of the original animation to have roughly the same visual effect as the white. ## Validation Steps Performed * Tested the two flashes on the default color schemes and some custom background colors to see if they look consistent * Used tracepoints and visual to check that the right animation is used (including multiple tabs, split windows with different themes, and changing settings while window is open) References #9270 Closes #13450 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29726
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?