starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13746] [MERGED] Add recursive_ticket_lock and use it for Terminal #29735

New Issue
Open
opened 2026-01-31 09:36:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13746
Author: @lhecker
Created: 8/15/2022
Status: ✅ Merged
Merged: 10/31/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/recursive-ticket-lock

📝 Commits (4)

  • 5be3b6d Add recursive_ticket_lock and use it for Terminal
  • 8b601f0 Fix debug build failure
  • 3a02bc0 Prevent recursive_ticket_lock_suspension misuse
  • 0257f01 Merge remote-tracking branch 'origin/main' into dev/lhecker/recursive-ticket-lock

📊 Changes

8 files changed (+128 additions, -69 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+1 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+3 -5)
📝 src/cascadia/TerminalCore/Terminal.cpp (+4 -16)
📝 src/cascadia/TerminalCore/Terminal.hpp (+4 -7)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+0 -3)
📝 src/host/consoleInformation.cpp (+8 -34)
📝 src/host/server.h (+8 -4)
📝 src/inc/til/ticket_lock.h (+100 -0)

📄 Description

My hope with this commit is to make our code more robust against accidental
recursive locking, as well as making it easier to write code with confidence,
with only a slight performance trade-off.

Validation Steps Performed

  • Playing Pac Man music through MIDI ✅
  • Windows Terminal runs happily ever after ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13746 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/15/2022 **Status:** ✅ Merged **Merged:** 10/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/recursive-ticket-lock` --- ### 📝 Commits (4) - [`5be3b6d`](https://github.com/microsoft/terminal/commit/5be3b6d395e7ef4c05f70561868d25c17cde0d3e) Add recursive_ticket_lock and use it for Terminal - [`8b601f0`](https://github.com/microsoft/terminal/commit/8b601f0a4cf87c8c604712ab21ffa280adef46d6) Fix debug build failure - [`3a02bc0`](https://github.com/microsoft/terminal/commit/3a02bc06168d7542a640fbf04a45b4506ea3f484) Prevent recursive_ticket_lock_suspension misuse - [`0257f01`](https://github.com/microsoft/terminal/commit/0257f01dab39cbf04c9db0e9628086de4d2779a4) Merge remote-tracking branch 'origin/main' into dev/lhecker/recursive-ticket-lock ### 📊 Changes **8 files changed** (+128 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+1 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+3 -5) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+4 -16) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+4 -7) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+0 -3) 📝 `src/host/consoleInformation.cpp` (+8 -34) 📝 `src/host/server.h` (+8 -4) 📝 `src/inc/til/ticket_lock.h` (+100 -0) </details> ### 📄 Description My hope with this commit is to make our code more robust against accidental recursive locking, as well as making it easier to write code with confidence, with only a slight performance trade-off. ## Validation Steps Performed * Playing Pac Man music through MIDI ✅ * Windows Terminal runs happily ever after ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?