starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13743] [MERGED] Update the default themes for 1.16 #29736

New Issue
Open
opened 2026-01-31 09:36:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13743
Author: @zadjii-msft
Created: 8/15/2022
Status: ✅ Merged
Merged: 8/31/2022
Merged by: @zadjii-msft

Base: main ← Head: dev/migrie/b/13554-new-default-theme

📝 Commits (10+)

  • 57e02b8 sometimes I do the code good
  • fe5a86d Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-inactiveTabBg
  • bdfb015 Allow the settings tab to also have a color set by the theme
  • 4146d71 default settings changes
  • f911929 transparent inactive tabs on light tab row, when the tabs have a dark FG color, works sanely now
  • 2964ebe comments
  • 37ce107 I can't tell you how much I hate this
  • 25e09d6 comments galore
  • b38b704 Merge branch 'dev/migrie/b/13554-new-default-theme' into dev/migrie/b/13684-inactiveTabBg
  • 48deba0 Revert the changes I made to the default themes

📊 Changes

15 files changed (+504 additions, -321 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+11 -2)
📝 src/cascadia/TerminalApp/SettingsTab.cpp (+19 -1)
📝 src/cascadia/TerminalApp/SettingsTab.h (+6 -1)
📝 src/cascadia/TerminalApp/TabBase.cpp (+289 -0)
📝 src/cascadia/TerminalApp/TabBase.h (+15 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+18 -70)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+5 -229)
📝 src/cascadia/TerminalApp/TerminalTab.h (+3 -12)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+3 -2)
📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+24 -0)
📝 src/cascadia/TerminalSettingsModel/Theme.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Theme.idl (+2 -0)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+22 -4)
📝 src/cascadia/WinRTUtils/inc/Utils.h (+63 -0)
📝 src/inc/til/color.h (+23 -0)

📄 Description

More or less, as in #13554

  • Dark theme by default (was system)
    • Justification:

      I think the interesting thing that we have today is that the color
      scheme is dark by default, but our window theme is set to system.
      System theme in Windows 11 is defaulted to light unless changed by
      the user. Now, we have a conflict between the theme and color scheme
      in Terminal.

      I think our options become, make the color scheme match "default"
      and set it to a light color scheme if the system theme is light, or
      manually match the theme to the color scheme by setting it to dark.

      Given that Terminal has historically had a black background with
      its Campbell color scheme, for a consistent UI experience, I'm
      voting to change the window theme to be dark by default as well.

  • tab.background: terminalBackground
  • Change the tab row colors back to "what they were pre-Controlsv2" more
    or less
    • The ramp is based off of "Light tab row background from Edge's
      unfocused titlebar color, inactive tab row color BG from the
      controlsv1 colors"
  • tabRow.unfocusedBackground set Transparent

Closes #13554

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13743 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/15/2022 **Status:** ✅ Merged **Merged:** 8/31/2022 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/13554-new-default-theme` --- ### 📝 Commits (10+) - [`57e02b8`](https://github.com/microsoft/terminal/commit/57e02b885be361129fe9e0ad0a3c9d904b1efc22) sometimes I do the code good - [`fe5a86d`](https://github.com/microsoft/terminal/commit/fe5a86d717ed422c80e5cc48780782e4cca8ff86) Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-inactiveTabBg - [`bdfb015`](https://github.com/microsoft/terminal/commit/bdfb015a3b339dd710fccd861e77b3552ff68bb1) Allow the settings tab to also have a color set by the theme - [`4146d71`](https://github.com/microsoft/terminal/commit/4146d71079a2a1c3812ee7b32457b1d4f1081bbf) default settings changes - [`f911929`](https://github.com/microsoft/terminal/commit/f911929e43cb612c30f316240366ee03cdb4361c) transparent inactive tabs on light tab row, when the tabs have a dark FG color, works sanely now - [`2964ebe`](https://github.com/microsoft/terminal/commit/2964ebe70ffe98ae22833d6954e82ce23b803ad1) comments - [`37ce107`](https://github.com/microsoft/terminal/commit/37ce10705a6b7d8d35f3ae25c04f9e79d552480d) I can't tell you how much I hate this - [`25e09d6`](https://github.com/microsoft/terminal/commit/25e09d695afa7d31f28fa61e25d7de126cb7c2df) comments galore - [`b38b704`](https://github.com/microsoft/terminal/commit/b38b7047bd9aae376e68762584d2fec74da12bef) Merge branch 'dev/migrie/b/13554-new-default-theme' into dev/migrie/b/13684-inactiveTabBg - [`48deba0`](https://github.com/microsoft/terminal/commit/48deba0245c801ed0e76a55f377c3e700b6ae718) Revert the changes I made to the default themes ### 📊 Changes **15 files changed** (+504 additions, -321 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+11 -2) 📝 `src/cascadia/TerminalApp/SettingsTab.cpp` (+19 -1) 📝 `src/cascadia/TerminalApp/SettingsTab.h` (+6 -1) 📝 `src/cascadia/TerminalApp/TabBase.cpp` (+289 -0) 📝 `src/cascadia/TerminalApp/TabBase.h` (+15 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+18 -70) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+5 -229) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+3 -12) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+3 -2) 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+24 -0) 📝 `src/cascadia/TerminalSettingsModel/Theme.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Theme.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+22 -4) 📝 `src/cascadia/WinRTUtils/inc/Utils.h` (+63 -0) 📝 `src/inc/til/color.h` (+23 -0) </details> ### 📄 Description More or less, as in #13554 * Dark theme by default (was `system`) * Justification: > I think the interesting thing that we have today is that the color > scheme is dark by default, but our window theme is set to system. > System theme in Windows 11 is defaulted to light unless changed by > the user. Now, we have a conflict between the theme and color scheme > in Terminal. > > I think our options become, make the color scheme match "default" > and set it to a light color scheme if the system theme is light, or > manually match the theme to the color scheme by setting it to dark. > > Given that Terminal has historically had a black background with > its Campbell color scheme, for a consistent UI experience, I'm > voting to change the window theme to be dark by default as well. * `tab.background: terminalBackground` * Change the tab row colors back to "what they were pre-Controlsv2" more or less - The ramp is based off of "Light tab row background from Edge's unfocused titlebar color, inactive tab row color BG from the controlsv1 colors" * `tabRow.unfocusedBackground` set `Transparent` Closes #13554 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?