starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13786] [MERGED] [1.14] Use the viewport-rel. cursor pos for CursorPosition #29767

New Issue
Open
opened 2026-01-31 09:36:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:36:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13786
Author: @DHowett
Created: 8/19/2022
Status: ✅ Merged
Merged: 8/22/2022
Merged by: @DHowett

Base: release-1.14 ← Head: dev/duhowett/the-cursor-is-too-far-AWAY-on-1.14-too

📝 Commits (1)

  • 19c3615 [1.14] Use the viewport-relative cursor pos for CCore.CursorPosition

📊 Changes

3 files changed (+12 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+9 -0)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -0)

📄 Description

In #13024, we removed Terminal::GetCursorPosition from TerminalCore.
This has been widely regarded as a good move.

Now, you might rightly be wondering: why didn't compilation immediately
fail? Well. It turns out that there were two copies of
GetCursorPosition. One for const Terminal, and one for Terminal.
This is important.

Terminal::GetCursorPosition() returned the cursor position relative to
the viewport. Terminal::GetCursorPosition() const, however, returns
the cursor position in absolute.

We removed the non-const one. Fortunately, thanks to the lookup rules
for const-qualified members, this didn't matter. Code that called
GetCursorPosition() still called GetCursorPosition(), and everything
was fine.

Except that part about the relative coordinates. That was not fine.

The TSF control is the only consumer of ControlCore.CursorPosition,
and that was the only consumer of relative-GetCursorPosition().

This commit restores equilibrium by introducing a new
GetViewportRelativeCursorPosition() member to Terminal and switching
over the only consumer of relative cursor position to use it.

Closes #13769.
Backport of #13785.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13786 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 8/19/2022 **Status:** ✅ Merged **Merged:** 8/22/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `release-1.14` ← **Head:** `dev/duhowett/the-cursor-is-too-far-AWAY-on-1.14-too` --- ### 📝 Commits (1) - [`19c3615`](https://github.com/microsoft/terminal/commit/19c3615963c1ed123227321bbdc8a2e556763564) [1.14] Use the viewport-relative cursor pos for CCore.CursorPosition ### 📊 Changes **3 files changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+9 -0) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -0) </details> ### 📄 Description In #13024, we removed `Terminal::GetCursorPosition` from TerminalCore. This has been widely regarded as a good move. Now, you might rightly be wondering: why didn't compilation immediately fail? Well. It turns out that there were _two_ copies of `GetCursorPosition`. One for `const Terminal`, and one for `Terminal`. This is important. `Terminal::GetCursorPosition()` returned the cursor position relative to the viewport. `Terminal::GetCursorPosition() const`, however, returns the cursor position in absolute. We removed the non-`const` one. Fortunately, thanks to the lookup rules for `const`-qualified members, this didn't matter. Code that called `GetCursorPosition()` still called `GetCursorPosition()`, and everything was fine. Except that part about the relative coordinates. That was not fine. The TSF control is the _only_ consumer of `ControlCore.CursorPosition`, and that was the _only_ consumer of relative-`GetCursorPosition()`. This commit restores equilibrium by introducing a new `GetViewportRelativeCursorPosition()` member to `Terminal` and switching over the only consumer of relative cursor position to use it. Closes #13769. Backport of #13785. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29767
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?