[PR #13871] [MERGED] Fixes the color of the dropdown arrow in weird themes #29799

Open
opened 2026-01-31 09:36:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13871
Author: @zadjii-msft
Created: 8/29/2022
Status: Merged
Merged: 8/31/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/13725-dropdown-color


📝 Commits (10+)

  • 57e02b8 sometimes I do the code good
  • fe5a86d Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-inactiveTabBg
  • bdfb015 Allow the settings tab to also have a color set by the theme
  • 4146d71 default settings changes
  • f911929 transparent inactive tabs on light tab row, when the tabs have a dark FG color, works sanely now
  • 2964ebe comments
  • 37ce107 I can't tell you how much I hate this
  • 25e09d6 comments galore
  • b38b704 Merge branch 'dev/migrie/b/13554-new-default-theme' into dev/migrie/b/13684-inactiveTabBg
  • 48deba0 Revert the changes I made to the default themes

📊 Changes

1 file changed (+15 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+15 -1)

📄 Description

See also:
33732458ed/dev/SplitButton/SplitButton.xaml (L290-L293)

We need to

  • Also set SplitButtonForegroundSecondary cause SplitButton's use that resource separately from the Foreground() property
  • Manually trigger the visual state change, to refresh the brushes. We do something similar in TabBase

This is one of the bullet points in #13725


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13871 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/29/2022 **Status:** ✅ Merged **Merged:** 8/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/13725-dropdown-color` --- ### 📝 Commits (10+) - [`57e02b8`](https://github.com/microsoft/terminal/commit/57e02b885be361129fe9e0ad0a3c9d904b1efc22) sometimes I do the code good - [`fe5a86d`](https://github.com/microsoft/terminal/commit/fe5a86d717ed422c80e5cc48780782e4cca8ff86) Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-inactiveTabBg - [`bdfb015`](https://github.com/microsoft/terminal/commit/bdfb015a3b339dd710fccd861e77b3552ff68bb1) Allow the settings tab to also have a color set by the theme - [`4146d71`](https://github.com/microsoft/terminal/commit/4146d71079a2a1c3812ee7b32457b1d4f1081bbf) default settings changes - [`f911929`](https://github.com/microsoft/terminal/commit/f911929e43cb612c30f316240366ee03cdb4361c) transparent inactive tabs on light tab row, when the tabs have a dark FG color, works sanely now - [`2964ebe`](https://github.com/microsoft/terminal/commit/2964ebe70ffe98ae22833d6954e82ce23b803ad1) comments - [`37ce107`](https://github.com/microsoft/terminal/commit/37ce10705a6b7d8d35f3ae25c04f9e79d552480d) I can't tell you how much I hate this - [`25e09d6`](https://github.com/microsoft/terminal/commit/25e09d695afa7d31f28fa61e25d7de126cb7c2df) comments galore - [`b38b704`](https://github.com/microsoft/terminal/commit/b38b7047bd9aae376e68762584d2fec74da12bef) Merge branch 'dev/migrie/b/13554-new-default-theme' into dev/migrie/b/13684-inactiveTabBg - [`48deba0`](https://github.com/microsoft/terminal/commit/48deba0245c801ed0e76a55f377c3e700b6ae718) Revert the changes I made to the default themes ### 📊 Changes **1 file changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+15 -1) </details> ### 📄 Description See also: https://github.com/microsoft/microsoft-ui-xaml/blob/33732458ede38166f9127675898e4760c82b89bb/dev/SplitButton/SplitButton.xaml#L290-L293 We need to * Also set `SplitButtonForegroundSecondary` cause SplitButton's use that resource separately from the `Foreground()` property * Manually trigger the visual state change, to refresh the brushes. We do something similar in TabBase This is one of the bullet points in #13725 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:36:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29799