starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #13926] [MERGED] Fix a few C++ Warnings, default a bunch of ctors/dtors #29828

New Issue
Open
opened 2026-01-31 09:37:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:37:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13926
Author: @SiliconA-Z
Created: 9/4/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @carlos-zamora

Base: main ← Head: OK

📝 Commits (2)

📊 Changes

45 files changed (+61 additions, -117 deletions)

View changed files

📝 src/buffer/out/cursor.cpp (+1 -3)
📝 src/cascadia/Remoting/Monarch.cpp (+1 -3)
📝 src/cascadia/TerminalApp/DebugTapConnection.cpp (+1 -3)
📝 src/cascadia/TerminalConnection/EchoConnection.cpp (+1 -3)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp (+1 -3)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+1 -3)
📝 src/cascadia/TerminalSettingsModel/IDynamicProfileGenerator.h (+1 -1)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+1 -3)
📝 src/host/cmdline.cpp (+1 -3)
📝 src/host/input.cpp (+2 -1)
📝 src/host/inputBuffer.cpp (+1 -3)
📝 src/host/inputKeyInfo.cpp (+1 -3)
📝 src/host/readDataDirect.cpp (+1 -3)
📝 src/host/readDataRaw.cpp (+1 -3)
📝 src/host/registry.cpp (+1 -3)
📝 src/inc/til/spsc.h (+1 -1)
📝 src/interactivity/win32/menu.cpp (+1 -3)
📝 src/renderer/inc/IRenderData.hpp (+1 -1)
📝 src/renderer/inc/IRenderEngine.hpp (+1 -3)

...and 25 more files

📄 Description

No behavioral changes, just some modernizations like replacing empty methods with default and using _v instead of ::value for some types.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13926 **Author:** [@SiliconA-Z](https://github.com/SiliconA-Z) **Created:** 9/4/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `OK` --- ### 📝 Commits (2) - [`74ec8dd`](https://github.com/microsoft/terminal/commit/74ec8dd2bccc4151d7fd8e3d4d3a316a5d316ab8) Some C++ fixes - [`db692a8`](https://github.com/microsoft/terminal/commit/db692a876fcef96815a28fa252c59a664aa7e3c5) Update src/types/KeyEvent.cpp ### 📊 Changes **45 files changed** (+61 additions, -117 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/cursor.cpp` (+1 -3) 📝 `src/cascadia/Remoting/Monarch.cpp` (+1 -3) 📝 `src/cascadia/TerminalApp/DebugTapConnection.cpp` (+1 -3) 📝 `src/cascadia/TerminalConnection/EchoConnection.cpp` (+1 -3) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp` (+1 -3) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+1 -3) 📝 `src/cascadia/TerminalSettingsModel/IDynamicProfileGenerator.h` (+1 -1) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+1 -3) 📝 `src/host/cmdline.cpp` (+1 -3) 📝 `src/host/input.cpp` (+2 -1) 📝 `src/host/inputBuffer.cpp` (+1 -3) 📝 `src/host/inputKeyInfo.cpp` (+1 -3) 📝 `src/host/readDataDirect.cpp` (+1 -3) 📝 `src/host/readDataRaw.cpp` (+1 -3) 📝 `src/host/registry.cpp` (+1 -3) 📝 `src/inc/til/spsc.h` (+1 -1) 📝 `src/interactivity/win32/menu.cpp` (+1 -3) 📝 `src/renderer/inc/IRenderData.hpp` (+1 -1) 📝 `src/renderer/inc/IRenderEngine.hpp` (+1 -3) _...and 25 more files_ </details> ### 📄 Description No behavioral changes, just some modernizations like replacing empty methods with default and using _v instead of ::value for some types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29828
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?