[PR #13946] [MERGED] Fix til::color::layer_over #29835

Open
opened 2026-01-31 09:37:10 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13946
Author: @zadjii-msft
Created: 9/8/2022
Status: Merged
Merged: 9/9/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/float-colors-are-hard


📝 Commits (3)

  • 25306f1 float math is hard
  • fffabf3 Merge remote-tracking branch 'origin/main' into dev/migrie/b/float-colors-are-hard
  • 3f5ec45 Fix til::color::layer_over

📊 Changes

2 files changed (+19 additions, -7 deletions)

View changed files

📝 src/inc/til/color.h (+4 -7)
📝 src/til/ut_til/ColorTests.cpp (+15 -0)

📄 Description

The color of inactive tab text is incorrect since #13689 due to the introduction
of til::color::layer_over which incorrectly calculated the RGB values.

Validation Steps Performed

  • Added unit tests

Co-authored-by: Leonard Hecker lhecker@microsoft.com


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13946 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/8/2022 **Status:** ✅ Merged **Merged:** 9/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/float-colors-are-hard` --- ### 📝 Commits (3) - [`25306f1`](https://github.com/microsoft/terminal/commit/25306f1bbb600cc67b66e18295bb7aa53bec64a3) float math is hard - [`fffabf3`](https://github.com/microsoft/terminal/commit/fffabf34bb458b7921c173111a0e70387980db29) Merge remote-tracking branch 'origin/main' into dev/migrie/b/float-colors-are-hard - [`3f5ec45`](https://github.com/microsoft/terminal/commit/3f5ec45a068444fb4bd241437e47b69e0a7b199c) Fix til::color::layer_over ### 📊 Changes **2 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/inc/til/color.h` (+4 -7) 📝 `src/til/ut_til/ColorTests.cpp` (+15 -0) </details> ### 📄 Description The color of inactive tab text is incorrect since #13689 due to the introduction of `til::color::layer_over` which incorrectly calculated the RGB values. ## Validation Steps Performed * Added unit tests ✅ Co-authored-by: Leonard Hecker <lhecker@microsoft.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:10 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29835