[PR #13935] [MERGED] Re-add support for Mica, transparent titlebars #29837

Open
opened 2026-01-31 09:37:10 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13935
Author: @zadjii-msft
Created: 9/6/2022
Status: Merged
Merged: 12/9/2022
Merged by: @undefined

Base: mainHead: dev/migrie/f/transparent-tab-row-002


📝 Commits (10+)

  • 8c3c8fe Revert "Remove the useMica key (#13872)"
  • 0a3a537 Clip the drag rect to the right side of the window. I don't think this really matters.
  • 2fcc420 add support for transparent titlebars back, for testing.
  • 337c5e9 hey this works - let's clean it up and figure out what is/n't important
  • c77173b Add better support in the Theme objects themselves for transparency
  • df6d4cd way easier
  • 2895a34 notes, mostly
  • c42965e Merge branch 'main' into dev/migrie/f/transparent-tab-row-002
  • e9f8569 hey, we can use the real api now
  • 4964d8b Merge remote-tracking branch 'origin/main' into dev/migrie/f/transparent-tab-row-002

📊 Changes

10 files changed (+94 additions, -69 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp (+11 -5)
📝 src/cascadia/TerminalControl/TermControl.cpp (+10 -2)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+3 -2)
📝 src/cascadia/TerminalSettingsModel/Theme.cpp (+1 -46)
📝 src/cascadia/TerminalSettingsModel/Theme.idl (+1 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+3 -11)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+13 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+2 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+45 -3)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+5 -0)

📄 Description

This reverts commit 19b6d35.

This re-enables support for Mica, and transparent titlebars in general. It also syncs the titlebar opacity with the control opacity for terminalBackground. It also somehow fixes the bug where the bottom few pixels of the max btn doesn't work to trigger the snap flyout.

Closes #10509

Does nothing for #13631

To-done's

  • Check the mica API on 22000, windows 11 RTM
    • this works on 10.0.22621.674, but that's not 22000
  • Check how this behaves on windows 10.
    • For both, this API just no-ops. That's fine! we can just say "Mica is only supported on >=22621"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13935 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/f/transparent-tab-row-002` --- ### 📝 Commits (10+) - [`8c3c8fe`](https://github.com/microsoft/terminal/commit/8c3c8fef8907293810390cea6d1c4489bef9b5e3) Revert "Remove the `useMica` key (#13872)" - [`0a3a537`](https://github.com/microsoft/terminal/commit/0a3a537c363dd587600f7caf47c440ba83604745) Clip the drag rect to the right side of the window. I don't think this really matters. - [`2fcc420`](https://github.com/microsoft/terminal/commit/2fcc420d84bd937f627118130cba8180d7ec4883) add support for transparent titlebars back, for testing. - [`337c5e9`](https://github.com/microsoft/terminal/commit/337c5e9a60911216b42f47b160e0fdcf0455493c) hey this works - let's clean it up and figure out what is/n't important - [`c77173b`](https://github.com/microsoft/terminal/commit/c77173ba7b0ddcc00b963633dd968510882ee3b5) Add better support in the Theme objects themselves for transparency - [`df6d4cd`](https://github.com/microsoft/terminal/commit/df6d4cd0aed277c13a09bd234517f521ba72e544) way easier - [`2895a34`](https://github.com/microsoft/terminal/commit/2895a34085f8878766458da6c53f648c29fc8924) notes, mostly - [`c42965e`](https://github.com/microsoft/terminal/commit/c42965ef29b6f9a8930f665cb645219b2529d802) Merge branch 'main' into dev/migrie/f/transparent-tab-row-002 - [`e9f8569`](https://github.com/microsoft/terminal/commit/e9f8569ea68c2c2ffc846b01b61182a4f08d2bca) hey, we can use the real api now - [`4964d8b`](https://github.com/microsoft/terminal/commit/4964d8b663e6bf530d02dc7fb9fb58378e51ab6c) Merge remote-tracking branch 'origin/main' into dev/migrie/f/transparent-tab-row-002 ### 📊 Changes **10 files changed** (+94 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/ThemeTests.cpp` (+11 -5) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+10 -2) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+3 -2) 📝 `src/cascadia/TerminalSettingsModel/Theme.cpp` (+1 -46) 📝 `src/cascadia/TerminalSettingsModel/Theme.idl` (+1 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+3 -11) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+13 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+2 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+45 -3) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+5 -0) </details> ### 📄 Description This reverts commit 19b6d35. This re-enables support for Mica, and transparent titlebars in general. It also syncs the titlebar opacity with the control opacity for `terminalBackground`. It also somehow fixes the bug where the bottom few pixels of the max btn doesn't work to trigger the snap flyout. Closes #10509 Does nothing for #13631 ### To-done's * [x] Check the mica API on 22000, windows 11 RTM - this works on 10.0.22621.674, but that's not 22000 * [x] Check how this behaves on windows 10. - For both, this API just no-ops. That's fine! we can just say "Mica is only supported on >=22621" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:10 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29837