[PR #13939] [MERGED] AtlasEngine: Remove experimental tag and add tracing #29839

Open
opened 2026-01-31 09:37:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13939
Author: @lhecker
Created: 9/7/2022
Status: Merged
Merged: 9/8/2022
Merged by: @undefined

Base: mainHead: dev/lhecker/atlas-engine-settings


📝 Commits (2)

  • 8f4997b AtlasEngine: Remove experimental tag and add tracing
  • bf204bf Address feedback

📊 Changes

9 files changed (+41 additions, -16 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+3 -3)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Rendering.xaml (+6 -0)
📝 src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/RenderingViewModel.h (+5 -6)
📝 src/cascadia/TerminalSettingsEditor/RenderingViewModel.idl (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+2 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+19 -0)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+1 -1)

📄 Description

With AtlasEngine being enabled by default in 1.16 Preview it would look weird
if the useAtlasEngine option would still be called "experimental".
Additionally we're interested in how many users opt out of useAtlasEngine,
indicating major issues that would require us to disable it by default again.

Related to #13936

Validation Steps Performed

  • Toggling useAtlasEngine works as expected
  • Observe new event with TVPP

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13939 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/7/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/atlas-engine-settings` --- ### 📝 Commits (2) - [`8f4997b`](https://github.com/microsoft/terminal/commit/8f4997bd16cb08d23b1b43b471cc3394cc1ce564) AtlasEngine: Remove experimental tag and add tracing - [`bf204bf`](https://github.com/microsoft/terminal/commit/bf204bf965e3623215fee84e69d8eb0875c64e62) Address feedback ### 📊 Changes **9 files changed** (+41 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+3 -3) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.xaml` (+6 -0) 📝 `src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/RenderingViewModel.h` (+5 -6) 📝 `src/cascadia/TerminalSettingsEditor/RenderingViewModel.idl` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+19 -0) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+1 -1) </details> ### 📄 Description With AtlasEngine being enabled by default in 1.16 Preview it would look weird if the `useAtlasEngine` option would still be called "experimental". Additionally we're interested in how many users opt out of useAtlasEngine, indicating major issues that would require us to disable it by default again. Related to #13936 ## Validation Steps Performed * Toggling `useAtlasEngine` works as expected ✅ * Observe new event with TVPP ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29839