[PR #13966] [MERGED] AtlasEngine: Fix a crash when drawing double width rows #29855

Open
opened 2026-01-31 09:37:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13966
Author: @lhecker
Created: 9/11/2022
Status: ✅ Merged
Merged: 9/15/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/atlas-engine-fixup


📝 Commits (2)

  • 1cf7f41 AtlasEngine: Fix a crash when drawing double width rows
  • c21e35a Address feedback, Fix AuditMode

📊 Changes

1 file changed (+24 additions, -0 deletions)

View changed files

📝 src/renderer/atlas/AtlasEngine.cpp (+24 -0)

📄 Description

The TileHashMap refresh via makeNewest() in StartPaint() depends
on us filling the entire cellGlyphMapping row with valid data.
This commit makes sure to initialize the cellGlyphMapping buffer.
Additionally it clears the rest of the row with whitespace
until proper LineRendition support is added.

Closes #13962

Validation Steps Performed

  • vttest's "Test of double-sized characters" stops crashing ✅
  • No weird leftover characters ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13966 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 9/11/2022 **Status:** ✅ Merged **Merged:** 9/15/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/atlas-engine-fixup` --- ### 📝 Commits (2) - [`1cf7f41`](https://github.com/microsoft/terminal/commit/1cf7f417f8c2a47e51d8fbca7de87ae93db035d2) AtlasEngine: Fix a crash when drawing double width rows - [`c21e35a`](https://github.com/microsoft/terminal/commit/c21e35aebc5961d8aff8e19dc98b15042f6fd470) Address feedback, Fix AuditMode ### 📊 Changes **1 file changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/atlas/AtlasEngine.cpp` (+24 -0) </details> ### 📄 Description The `TileHashMap` refresh via `makeNewest()` in `StartPaint()` depends on us filling the entire `cellGlyphMapping` row with valid data. This commit makes sure to initialize the `cellGlyphMapping` buffer. Additionally it clears the rest of the row with whitespace until proper `LineRendition` support is added. Closes #13962 ## Validation Steps Performed * vttest's "Test of double-sized characters" stops crashing ✅ * No weird leftover characters ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:37:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29855